From owner-freebsd-current@FreeBSD.ORG Wed Sep 28 07:51:49 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F2AF106564A for ; Wed, 28 Sep 2011 07:51:49 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9FA968FC13 for ; Wed, 28 Sep 2011 07:51:48 +0000 (UTC) Received: by fxg9 with SMTP id 9so417246fxg.13 for ; Wed, 28 Sep 2011 00:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=j/08bqE2SDBnz/LamUGbAGkvd4bDYAZMJIsaJTnpSEA=; b=w74RgFsC26PFjqdVRQoS7HVrX55Vh8htiXdKwktFVp1q3AJLX2DuQ4KD8A5M1DPV8l cJNP2EHgCMjMgsjgDU0nGiH+NURBKpc0LjksygntTrMaYGrCmABYO3c8B0Gy8eaXYJde eN+WYNOhsAYmpqon4Jr54GZmtSFPV5oaG9BpQ= Received: by 10.223.42.24 with SMTP id q24mr5369849fae.45.1317196307709; Wed, 28 Sep 2011 00:51:47 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua. [212.86.226.226]) by mx.google.com with ESMTPS id o22sm26433263fab.11.2011.09.28.00.51.45 (version=SSLv3 cipher=OTHER); Wed, 28 Sep 2011 00:51:46 -0700 (PDT) Sender: Alexander Motin Message-ID: <4E82D20C.4040600@FreeBSD.org> Date: Wed, 28 Sep 2011 10:51:40 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Craig Rodrigues References: In-Reply-To: X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: Compat symlinks for /dev/acd0? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2011 07:51:49 -0000 Craig Rodrigues wrote: > When the ATA_CAM option is enabled in the kernel, we create > compatibility symlinks for /dev/ada devices, such as: /dev/ad8s1@ -> ada0s1 > > We don't do this for ATAPI CD-ROM devices. > > Any reason *not* to do this for ATAPI CD-ROM devices? i.e. /dev/cd0 -> acd0 I see no strong reason why it should not be done, but either I see no much reasons to do it: 1. acdX (same as other ATAPI devices) had no static IDs, that are difficult to map manually in case of adX; 2. in opposite to 1, it is not reliable to automatically predict that cdX always maps to acdX when there is more then one CD, especially if some of them are not ATA; I really wouldn't like to track second set of device unit numbers, existing now quirks are very noninvasive; 3. half of CD operation is writing and linking to the device with different API won't help it; > It's a minor thing, but will definitely hit people who have /dev/acd0 > in /etc/fstab when they upgrade to 9.0. adX->adaY change is a major hit for majority of people because their systems just won't boot without these links. Same time I have doubt that many people are automatically mount their CDs on boot from the fstab and many system won't boot even without CDs at all. > People can read UPDATING and the release notes, but if we can do this > minor thing, it might make migration easier. At some moment user still have to read UPDATING or release notes and update fstab. It is quite easy to create cdX to acdX symlinks. I've made a patch in five minutes. Is there anybody else who thinks I should commit it? -- Alexander Motin