From owner-cvs-all Tue Jan 14 2: 8:36 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C422937B401; Tue, 14 Jan 2003 02:08:34 -0800 (PST) Received: from axl.seasidesoftware.co.za (axl.seasidesoftware.co.za [196.31.7.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37D3543F7C; Tue, 14 Jan 2003 02:08:29 -0800 (PST) (envelope-from sheldonh@starjuice.net) Received: from sheldonh by axl.seasidesoftware.co.za with local (Exim 4.10) id 18YNzZ-000Jgw-00; Tue, 14 Jan 2003 12:08:21 +0200 Date: Tue, 14 Jan 2003 12:08:21 +0200 From: Sheldon Hearn To: Matt Dillon Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/dump Makefile cache.c dump.8 dump.h main.c traverse.c Message-ID: <20030114100821.GE61405@starjuice.net> Mail-Followup-To: Matt Dillon , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200301131942.h0DJgfbN010760@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200301131942.h0DJgfbN010760@repoman.freebsd.org> User-Agent: Mutt/1.5.3i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On (2003/01/13 11:42), Matt Dillon wrote: > Modified files: > sbin/dump Makefile dump.8 dump.h main.c traverse.c > Added files: > sbin/dump cache.c > Log: > Add a caching option to dump. Use -C. Note that NetBSD has a caching option > called -r but it takes 512 byte blocks instead of megabytes, and I felt a > megabytes specification would be far more useful so I did not use the same > option character. [...] First, let me say that this looks very cool. > MFC after: 3 days However, I'd like you to wait with respect to merging. I don't want this option to hit production lines until it's clear that the compatibility camp is okay with offering similar functionality to that found in NetBSD, without using the same option. For example, if OpenBSD also add NetBSD's -r, then we're the odd man out. If the only justification is the one you gave in your commit log (megabytes are easier to work with than 512 byte blocks), then I suspect it might be worthwhile to get in line with NetBSD before merging. So could you hold off for, say 2 weeks, before merging? I think this will allow enough time for the issue to be discussed and resolved. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message