From owner-freebsd-current@FreeBSD.ORG Thu Dec 4 15:01:03 2008 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F09CE1065677; Thu, 4 Dec 2008 15:01:03 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id C66B68FC0A; Thu, 4 Dec 2008 15:01:03 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id 291901CBB41; Thu, 4 Dec 2008 09:42:55 -0500 (EST) Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 04 Dec 2008 09:42:55 -0500 X-Sasl-enc: 0ganI11VmyIvDLNqNKSMqH7QLKUarCt1igxl6J2gpO1I 1228401774 Received: from empiric.lon.incunabulum.net (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id 972453AFCD; Thu, 4 Dec 2008 09:42:54 -0500 (EST) Message-ID: <4937EC6D.7050703@FreeBSD.org> Date: Thu, 04 Dec 2008 14:42:53 +0000 From: "Bruce M. Simpson" User-Agent: Thunderbird 2.0.0.14 (X11/20080514) MIME-Version: 1.0 To: John Baldwin References: <200811191503.02192.jhb@freebsd.org> In-Reply-To: <200811191503.02192.jhb@freebsd.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@FreeBSD.org Subject: Re: [PATCH] ppbus/ppc locking X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2008 15:01:04 -0000 John Baldwin wrote: > Please test! This is the last non-MPSAFE network driver at this point. This > patch adds locking for the ppbus(4)/ppc(4) devices and the various ppbus > child devices (lpt, vpo, lpbb, ppi, pps). The basic model is that a single > mutex in the ppc(4) driver protects the ppc0 hardware and is shared with the > various child drivers. Two drivers now have detach methods that did not have > them before (plip and ppi). I've done some simple testing on my laptop (able > to load the drivers and do some simple things w/o panic'ing or tripping > assertions), but I am not really able to test the peripheral drivers fully. > > http://www.FreeBSD.org/~jhb/patches/ppc_locking.patch > > Runway lpt Giant is an occasionally show stopping issue for me because my printer is attached via the plt port. I may get time to look at this later on... I tried applying these patches against 7-STABLE. ppc_cleanup.patch applied OK to 7. ppc_intr.patch applied OK to 7 with interrupt.h change manually merged, and some fixups to ppc.c for earlier intr_event kpi. ppc_locking.patch does not apply cleanly, and it's too much for me to deal with right now. I found I had to hack up an existing 7 tree in /usr/src to get things to compile because of the wide scope of the changes (touching kern, sys etc), I couldn't just use an svn checkout to work from. cheers BMS