From owner-svn-src-head@freebsd.org Thu Dec 28 18:51:36 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60384EAE171; Thu, 28 Dec 2017 18:51:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2A81D65CE2; Thu, 28 Dec 2017 18:51:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id vBSIpZKP058666; Thu, 28 Dec 2017 18:51:35 GMT (envelope-from jhb@FreeBSD.org) Received: (from jhb@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id vBSIpZxV058665; Thu, 28 Dec 2017 18:51:35 GMT (envelope-from jhb@FreeBSD.org) Message-Id: <201712281851.vBSIpZxV058665@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jhb set sender to jhb@FreeBSD.org using -f From: John Baldwin Date: Thu, 28 Dec 2017 18:51:35 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r327292 - head/sys/dev/pccard X-SVN-Group: head X-SVN-Commit-Author: jhb X-SVN-Commit-Paths: head/sys/dev/pccard X-SVN-Commit-Revision: 327292 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2017 18:51:36 -0000 Author: jhb Date: Thu Dec 28 18:51:35 2017 New Revision: 327292 URL: https://svnweb.freebsd.org/changeset/base/327292 Log: Minor formatting and style tweaks to some comments. Modified: head/sys/dev/pccard/pccardvar.h Modified: head/sys/dev/pccard/pccardvar.h ============================================================================== --- head/sys/dev/pccard/pccardvar.h Thu Dec 28 17:55:58 2017 (r327291) +++ head/sys/dev/pccard/pccardvar.h Thu Dec 28 18:51:35 2017 (r327292) @@ -89,15 +89,14 @@ struct pccard_product { /** * Note: There's no cis3 or cis4 reported for NOMATCH / pnpinfo events for - * pccard It's unclear if we actually need that for automatic loading or - * not. These stirngs are informative, according to the standard. Some Linux - * drivers match on them, for example. However, FreeBSD's hardware probing is a - * little different than Linux so it turns out we don't need them. Some cards - * use CIS3 or CIS4 for a textual representation of the MAC address. In short, - * they aren't needed even though our friends in Linux have them. It is my + * pccard. It's unclear if we actually need that for automatic loading or + * not. These strings are informative, according to the standard. Some Linux + * drivers match on them, for example. However, FreeBSD's hardware probing is a + * little different than Linux, so it turns out we don't need them. Some cards + * use CIS3 or CIS4 for a textual representation of the MAC address. In short, * belief that all the entries in Linux don't actually need to be separate there - * either, but it's hard to eliminate them and retest on old, possibly rare, - * hardware so they persist. Despite years of collecting ~300 different PC Cards + * either, but they persist since it's hard to eliminate them and retest on old, + * possibly rare, hardware. Despite years of collecting ~300 different PC Cards * off E-Bay, I've not been able to find any that need CIS3/CIS4 to select which * device attaches. */ @@ -111,7 +110,7 @@ typedef int (*pccard_product_match_fn) (device_t dev, #include "card_if.h" /* - * make this inline so that we don't have to worry about dangling references + * Make this inline so that we don't have to worry about dangling references * to it in the modules or the code. */ static inline const struct pccard_product *