From owner-svn-src-all@FreeBSD.ORG  Thu Jun 10 15:30:45 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 33327106567C;
	Thu, 10 Jun 2010 15:30:45 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id E6E118FC08;
	Thu, 10 Jun 2010 15:30:44 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o5AFOxww038374;
	Thu, 10 Jun 2010 09:24:59 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Thu, 10 Jun 2010 09:25:02 -0600 (MDT)
Message-Id: <20100610.092502.72112000528403516.imp@bsdimp.com>
To: rdivacky@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <201006091957.o59JvKbu025122@svn.freebsd.org>
References: <201006091957.o59JvKbu025122@svn.freebsd.org>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r208964 - in head: . etc/mtree lib share/mk usr.bin
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jun 2010 15:30:45 -0000

In message: <201006091957.o59JvKbu025122@svn.freebsd.org>
            Roman Divacky <rdivacky@freebsd.org> writes:
: Modified: head/share/mk/bsd.own.mk
: ==============================================================================
: --- head/share/mk/bsd.own.mk	Wed Jun  9 19:32:20 2010	(r208963)
: +++ head/share/mk/bsd.own.mk	Wed Jun  9 19:57:20 2010	(r208964)
: @@ -288,6 +288,18 @@ _no_fdt= FDT
:  .endif
:  
:  #
: +# Default behaviour of MK_CLANG depends on the architecture.
: +#
: +.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386" || \
: +    ${MACHINE_ARCH} == "powerpc"
: +_clang_yes=CLANG
: +_clang_no=
: +.else
: +_clang_yes=
: +_clang_no=CLANG
: +.endif

We really should *NOT* be encoding architecture stuff like this into
bsd.own.mk.  Sometimes the right thing here is MACHINE_ARCH, and for
the moment, since clang is not a bootstrap tool, this is correct.
However, once clang is a bootstrap tool, this will be incorrect
because during the bootstrapping for cross building TARGET_ARCH is
what should be tested.  We have the same problem with the FTD stuff
that was recently committed.  raj@ and I have been talking about the
best ways to fix it.

I'm merging my tbemd code in the next few days/weeks and hope to start
to address this problem.  It already starts to address the insanity we
have in the Makefile.incs.

Warner