From owner-freebsd-current@FreeBSD.ORG Thu Aug 19 06:41:48 2010 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8020710656AB for ; Thu, 19 Aug 2010 06:41:48 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 2AA898FC1B for ; Thu, 19 Aug 2010 06:41:47 +0000 (UTC) Received: (qmail 22895 invoked by uid 399); 19 Aug 2010 06:41:47 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 19 Aug 2010 06:41:47 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C6CD229.1010401@FreeBSD.org> Date: Wed, 18 Aug 2010 23:41:45 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.8) Gecko/20100807 Thunderbird/3.1.2 MIME-Version: 1.0 To: Gabor Kovesdan X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: delphij@FreeBSD.org, current@FreeBSD.org Subject: BSD grep performance X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2010 06:41:48 -0000 On 08/18/2010 10:48, Gabor Kovesdan wrote: > I've just committed a patch with the kind help of Dimitry Andric, > which gives BSD grep a huge performance boost. Agreed, as I reported earlier. > The performance is now almost comparable to GNU grep. I think you're using a very liberal definition of "comparable." http://people.freebsd.org/~dougb/grep-time-trial.sh.txt http://people.freebsd.org/~dougb/grep-time-trial-2.sh.txt ./grep-time-trial GNU grep Elapsed time: 2 seconds BSD grep Elapsed time: 15 seconds ./grep-time-trial-2 GNU grep Elapsed time: 3 seconds BSD grep Elapsed time: 11 seconds > I think with this, BSD grep may remain default if no other serious > issues come up. I'm not going to re-state my opinion here except to say it hasn't changed. Even if the performance were not an issue I think the bugs mentioned below combined with your 4-day absence should also have been considerations. However, in regards to this particular case I think it's pretty obvious that I'm either alone, or in a very non-vocal group; so c'est la vie. However, from the standpoint of committer relations I think that first stating that you would change the default, then not doing so before all of the outstanding issues were resolved is not what I would consider a good model for others to follow. FWIW, Doug > Please report if you notice something weird. > > I know about some minor issues, which aren't fixed yet. I'll be out > for 4 days as of tomorrow but when I come back I'll take care of > these:- Infinite loop when reading directory on ZFS/NFS filesystem > - Problems with context grepping