From owner-svn-src-head@freebsd.org Tue Jun 2 15:14:10 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C583D2F2126; Tue, 2 Jun 2020 15:14:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49bwYZ4pxdz45XQ; Tue, 2 Jun 2020 15:14:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-274.local (unknown [IPv6:2601:648:8203:2990:b194:c7cf:2443:aa95]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 362961BA92; Tue, 2 Jun 2020 15:14:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: svn commit: r361712 - in head/sys/modules: . tcp To: Kyle Evans Cc: src-committers , svn-src-all , svn-src-head References: <202006020032.0520Wbke002516@repo.freebsd.org> <1b2dbc65-197d-a62b-3ba7-2cf78819277c@FreeBSD.org> From: John Baldwin Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: Date: Tue, 2 Jun 2020 08:14:09 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 15:14:10 -0000 On 6/2/20 8:08 AM, Kyle Evans wrote: > On Tue, Jun 2, 2020 at 10:07 AM John Baldwin wrote: >> >> On 6/1/20 5:32 PM, Kyle Evans wrote:> > Author: kevans >>> Date: Tue Jun 2 00:32:36 2020 >>> New Revision: 361712 >>> URL: https://svnweb.freebsd.org/changeset/base/361712 >>> >>> Log: >>> modules: don't build ipsec/tcpmd5 if the kernel is configured for IPSEC >>> >>> IPSEC_SUPPORT can currently only cope with either IPSEC || IPSEC_SUPPORT, >>> not both. Refrain from building if IPSEC is set, as the resulting module >>> won't be able to load anyways if it's built into the kernel. >>> >>> KERN_OPTS is safe here; for tied modules, it will reflect the kernel >>> configuration. For untied modules, it will defer to whatever is set in >>> ^/sys/conf/config.mk, which doesn't set IPSEC for modules. The latter >>> situation has some risk to it for uncommon scenarios, but such is the life >>> of untied kernel modules. >>> >>> Reported by: jenkins (a lot), O. Hartmann (once) >>> Generally discussed with: imp, jhb >>> >>> Modified: >>> head/sys/modules/Makefile >>> head/sys/modules/tcp/Makefile >>> >>> Modified: head/sys/modules/Makefile >>> ============================================================================== >>> --- head/sys/modules/Makefile Tue Jun 2 00:03:26 2020 (r361711) >>> +++ head/sys/modules/Makefile Tue Jun 2 00:32:36 2020 (r361712) >>> @@ -427,7 +427,7 @@ _if_enc= if_enc >>> _if_gif= if_gif >>> _if_gre= if_gre >>> _ipfw_pmod= ipfw_pmod >>> -.if ${KERN_OPTS:MIPSEC_SUPPORT} >>> +.if ${KERN_OPTS:MIPSEC_SUPPORT} && !${KERN_OPTS:MIPSEC} >>> _ipsec= ipsec >>> .endif >>> .endif >>> >>> Modified: head/sys/modules/tcp/Makefile >>> ============================================================================== >>> --- head/sys/modules/tcp/Makefile Tue Jun 2 00:03:26 2020 (r361711) >>> +++ head/sys/modules/tcp/Makefile Tue Jun 2 00:32:36 2020 (r361712) >>> @@ -16,7 +16,7 @@ _tcp_rack= rack >>> >>> .if (${MK_INET_SUPPORT} != "no" || ${MK_INET6_SUPPORT} != "no") || \ >>> defined(ALL_MODULES) >>> -.if ${KERN_OPTS:MIPSEC_SUPPORT} >>> +.if ${KERN_OPTS:MIPSEC_SUPPORT} && !${KERN_OPTS:MIPSEC} >> >> Thanks. >> >> Was finally getting back to this this morning. This one should be TCP_SIGNATURE, >> not IPSEC. (This would break for a kernel which doesn't have IPSEC but does >> have TCP_SIGNATURE.) >> > > Whoops. =-( No worries. I just finished a LINT build with that change. I'll make sure a full tinderbox passes ok though. -- John Baldwin