From owner-svn-src-all@FreeBSD.ORG Tue Oct 16 15:33:54 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1F582F38 for ; Tue, 16 Oct 2012 15:33:54 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm31-vm2.bullet.mail.gq1.yahoo.com (nm31-vm2.bullet.mail.gq1.yahoo.com [98.136.216.209]) by mx1.freebsd.org (Postfix) with ESMTP id 81EF68FC0A for ; Tue, 16 Oct 2012 15:33:52 +0000 (UTC) Received: from [98.137.12.58] by nm31.bullet.mail.gq1.yahoo.com with NNFMP; 16 Oct 2012 15:33:46 -0000 Received: from [208.71.42.211] by tm3.bullet.mail.gq1.yahoo.com with NNFMP; 16 Oct 2012 15:33:46 -0000 Received: from [127.0.0.1] by smtp222.mail.gq1.yahoo.com with NNFMP; 16 Oct 2012 15:33:46 -0000 X-Yahoo-Newman-Id: 731742.66271.bm@smtp222.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: bppjZxUVM1kmpvMJ7prrdliZUEYroUm82CbZiX8zd9tq7C0 avrVgh2UFHQeY_ljoRU9VjoQyG0Rq_7X7ouZ36iCy_SRBLBoJKVayEmRqd25 uR48mSnUxXhmFA.lS7keLWfFlvrn6LF_wDvCU6MtFcF4lIJpiV7um.FCb0Qz 4Hoh52gtQR.vrh9FIPclvRB4HGKXRqvjhqDGM28284puOg_s6cxz18GS0Y8v ysLPQzgMAVpck9QkX8IU1BhP9f_4GRsQjSzr9MdPkJGI0TnM2M.SaDCPGeBL duIXKdpZLYjRzEhAGXQb346i_pDvmIZVnOs30DBa5ZpM63F521lnYfKneSaT YSeNQqLeqmS1ldpXz6dbrDu3qB4CUmR6QItFOIA3NXTEKXqupbCrYiiaAZpo .kemojH4uhwE4X1s2Tdphk5QrEzglQt.WYyzyJ9rMYgOYrImZXTJjP83u3jC yEEGrPN..NHtbZhoLyCqHlBRgi3IPVTVMb_qqZX1g_iIC.ZP3BgLxmI0PJEp A6ITt0YHhHSn60roC412X7ulPkLG2Jue6.pbbF_4vRwdhHZ6_71RxkZMZpQo - X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Received: from [192.168.10.101] (pfg@200.118.157.7 with plain) by smtp222.mail.gq1.yahoo.com with SMTP; 16 Oct 2012 08:33:46 -0700 PDT Message-ID: <507D7E60.90204@FreeBSD.org> Date: Tue, 16 Oct 2012 10:33:52 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120621 Thunderbird/13.0.1 MIME-Version: 1.0 To: Rick Macklem Subject: Re: svn commit: r241601 - in stable/9: lib/libc/rpc sys/rpc References: <765985284.2313601.1350394614176.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <765985284.2313601.1350394614176.JavaMail.root@erie.cs.uoguelph.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2012 15:33:54 -0000 Thank you for the note Rick; On 10/16/2012 08:36, Rick Macklem wrote: > Pedro F. Giffuni wrote: >> Author: pfg >> Date: Tue Oct 16 01:37:17 2012 >> New Revision: 241601 >> URL: http://svn.freebsd.org/changeset/base/241601 >> >> Log: >> MFC r241143: >> >> rpc: be sure to free cl_netid and cl_tp. >> >> When creating a client with clnt_tli_create, it uses strdup to copy >> strings for these fields if nconf is passed in. clnt_dg_destroy frees >> these strings already. Make sure clnt_vc_destroy frees them in the >> same >> way. >> > I think the patch is fine. However, just fyi, there is no clnt_tli_create() > in the kernel and nothing in the kernel currently sets cl_netid or cl_tp non-NULL, as > far as I can see. The sys/ part is indeed there only to keep consistency with the libc version from which it was derived. According to OpenGrok though: clnt_tli_create() is declared extern in sys/rpc/clnt.h and used in lines 328 and 423 in sys/rpc/rpc_clnt.c. This can all be dead code but JIC it seems good to keep the check. Cheers, Pedro.