From nobody Wed Mar 11 13:16:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fWB926ffzz6V964 for ; Wed, 11 Mar 2026 13:16:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fWB925xvTz49cj for ; Wed, 11 Mar 2026 13:16:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773234998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xb4AMyr5jp77TO4Rbjp+IoBJHfCYKvDQfGJVAe+HVlM=; b=o2WOBCkzxktnHFT20dOuSgXrggMEfTZqOCplKDPPnal2OlcnR/Y9s8YcLdcd5w8TsfxrV8 rdTVGSy1h2MW1lqMWQ+w4d1cnevgf4nUWz64j8TdahP2fhzBtFsJXoabmVNZL47JihRG9V K/csRyhrqqt/6Q7V0p3WfjOEPbSU9C8+odWbwWdneFeQQLFs1Ejx3Tv6pBWjbsqp2zZG/L MAwDNe85flb44kiR/QD8ej8HhhMyesLD7ZzxQFQHY1Ey5z+8Bb0pYyKPtxpBPsN62jT93e 1Yp8m8xKmRSFGKK2OHouX+xvv3oSon04RdKWAntMN6f53tlajB7bDg5uwF2rEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773234998; a=rsa-sha256; cv=none; b=oehuXn+16u5InzIYtEkwb71Xh03GF48SyHliCcZTd/XD/z3cD7M2oGixxBeAeOsxawO4F4 ZnG9ahhxUIFhvgOr/LeazOjErLHWFeWxf/Pw5uHIFQ3fczZLuCtllGgQEJUTrnremcYSPO Bl+76chnoY9CAsM2g98btJ+tUP3EKoNiJ6Yf7iGfeY8+XEODDEhwqYqz3y9J1IKiDHr3Bd 8lwoVqUSvSCfkgtFSfTuGIJEpZ5VQHiZ/sopU16yGomEYppGwkQm2nwWa/c+jNrGdrcjrh 01ydO1j8a9bXtwK6JLZKegJSa00t0IswWTOVSrXHKSsRix/gDYLnILO4O6kVlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773234998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xb4AMyr5jp77TO4Rbjp+IoBJHfCYKvDQfGJVAe+HVlM=; b=XFz3YpSlwfQPXMxtb4kd58idbABg2ZYmGt7hT0N9/mvAuRVVzapH6Qzdx6V4/rPWqNE0kk be2o8JYBZR+vIh2pKNG71+zauDTEJVEWZdNwrMeGcm/zWEErIffAwnaqOEvDseIqGlky+U 1p7nTU7IbhBZaymxpmOhdJO/MsQf/jIR2mxnG55KI0DzBcfgIHL55EHOkuhrOKchZd3clm NHdQai4TW3d/5YjsvZR6Bu/UDopgj9hFsekcUII7BZko5VXkDIjfZ7XZeaUFMmgSNkZBEA 3hX09U3nrZVPGk2tI3kjrErZE/HqYthHW+GFWXXsuHbPxyCZ8xA82Wv8gRyedw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fWB925Pcdz114j for ; Wed, 11 Mar 2026 13:16:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 275ef by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Mar 2026 13:16:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 3d394a1da079 - stable/15 - system(3): Unwrap execve() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 3d394a1da0798cbe8fa07bbc92dab14ad4c4fff1 Auto-Submitted: auto-generated Date: Wed, 11 Mar 2026 13:16:38 +0000 Message-Id: <69b16b36.275ef.6ffc5448@gitrepo.freebsd.org> The branch stable/15 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=3d394a1da0798cbe8fa07bbc92dab14ad4c4fff1 commit 3d394a1da0798cbe8fa07bbc92dab14ad4c4fff1 Author: Dag-Erling Smørgrav AuthorDate: 2026-03-04 15:22:42 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-03-11 13:16:00 +0000 system(3): Unwrap execve() There is no need to call execl(), which will allocate an array and copy our arguments into it, when we can use a static array and call execve() directly. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D55648 (cherry picked from commit 40e52e0edd038460a2a2aca017b3ac5a513fe37b) --- lib/libc/stdlib/system.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/libc/stdlib/system.c b/lib/libc/stdlib/system.c index 94f7460c9b68..a2f472502bfd 100644 --- a/lib/libc/stdlib/system.c +++ b/lib/libc/stdlib/system.c @@ -60,6 +60,8 @@ __libc_system(const char *command) static struct sigaction ointact, oquitact; struct sigaction ign; sigset_t sigblock, osigblock; + char *argv[] = { "sh", "-c", __DECONST(char *, command), NULL }; + extern char **environ; int pstat = -1, serrno = 0; pid_t pid; @@ -101,7 +103,7 @@ __libc_system(const char *command) /* * Exec the command. */ - execl(_PATH_BSHELL, "sh", "-c", command, NULL); + _execve(_PATH_BSHELL, argv, environ); _exit(127); } else { /* parent */ /*