Date: Fri, 15 Sep 2023 21:45:46 +0100 From: Graham Perrin <grahamperrin@gmail.com> To: "Kevin P. Neal" <kpn@neutralgood.org> Cc: FreeBSD questions <freebsd-questions@freebsd.org> Subject: Re: git-rebase(1) prior to a PR in in the github.com/freebsd area Message-ID: <41a7534c-566c-2a45-6566-2660225158a9@gmail.com> In-Reply-To: <ZQOwIJmGtfLZn41N@neutralgood.org> References: <e49bc6e0-1380-0dc9-40ab-8865ae546a74@gmail.com> <20230827083631.192eb52f7b99e9ebd6b54ccf@sohara.org> <ee842be3-5458-872d-b3b1-f4dc64fcacd4@gmail.com> <20230827191324.eb8e546fdfb61469dd14bc5a@sohara.org> <55dc4697-dafe-19fe-0017-20a6effbac2b@gmail.com> <20230827213415.27b35f49feaf6b6959f9df7c@sohara.org> <be9d4518-99e4-4650-ed40-55f623faf4c8@gmail.com> <ZQOwIJmGtfLZn41N@neutralgood.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15/09/2023 02:15, Kevin P. Neal wrote: >> … >> >> % git -C /usr/src log -n 1 >> commit 9de94bcad3dab199829e2755e816a1b30e23054c (HEAD -> bhyve, >> origin/bhyve) >> Author: Graham Perrin<grahamperrin@gmail.com> >> Date: Sat Aug 19 08:41:09 2023 +0100 > Is that the right date? Good point, thanks. It does precede me taking the hints about additional changes, however I'm inclined to not fix the date in this case (unless it's requested as part of the review). Less noise. > When I squash a branch I never get the right > timestamp. I think it reuses the timestamp from first commit that > is "pick" instead of "squash". But I think "git commit --amend --date=now" > is good enough for me. Or something like that... I don't have my notes > handy. <https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---dateltdategt>;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41a7534c-566c-2a45-6566-2660225158a9>