From owner-svn-src-all@FreeBSD.ORG  Wed Jan 12 16:16:55 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 30EAA106566B;
	Wed, 12 Jan 2011 16:16:55 +0000 (UTC) (envelope-from pjd@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 1FC458FC12;
	Wed, 12 Jan 2011 16:16:55 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p0CGGtOL094634;
	Wed, 12 Jan 2011 16:16:55 GMT (envelope-from pjd@svn.freebsd.org)
Received: (from pjd@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id p0CGGtwM094632;
	Wed, 12 Jan 2011 16:16:55 GMT (envelope-from pjd@svn.freebsd.org)
Message-Id: <201101121616.p0CGGtwM094632@svn.freebsd.org>
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Date: Wed, 12 Jan 2011 16:16:55 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r217312 - head/sbin/hastd
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jan 2011 16:16:55 -0000

Author: pjd
Date: Wed Jan 12 16:16:54 2011
New Revision: 217312
URL: http://svn.freebsd.org/changeset/base/217312

Log:
  execve(2), not fork(2) resets signal handler to the default value (if it isn't
  ignored). Correct comment talking about that.
  
  Pointed out by:	kib
  MFC after:	3 days

Modified:
  head/sbin/hastd/hooks.c

Modified: head/sbin/hastd/hooks.c
==============================================================================
--- head/sbin/hastd/hooks.c	Wed Jan 12 16:00:49 2011	(r217311)
+++ head/sbin/hastd/hooks.c	Wed Jan 12 16:16:54 2011	(r217312)
@@ -373,9 +373,9 @@ hook_execv(const char *path, va_list ap)
 		PJDLOG_VERIFY(sigemptyset(&mask) == 0);
 		PJDLOG_VERIFY(sigprocmask(SIG_SETMASK, &mask, NULL) == 0);
 		/*
-		 * Dummy handler set for SIGCHLD in the parent should be
-		 * changed after fork(2) automatically to the default SIG_IGN,
-		 * so there is no need to do anything with it.
+		 * Dummy handler set for SIGCHLD in the parent will be restored
+		 * to SIG_IGN on execv(3) below, so there is no need to do
+		 * anything with it.
 		 */
 		execv(path, args);
 		pjdlog_errno(LOG_ERR, "Unable to execute %s", path);