From owner-cvs-all@FreeBSD.ORG Wed Jan 11 17:34:44 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 5EDC4106566C; Wed, 11 Jan 2012 17:34:44 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id C0C6A1546CB; Wed, 11 Jan 2012 17:34:42 +0000 (UTC) Message-ID: <4F0DC833.6000705@FreeBSD.org> Date: Wed, 11 Jan 2012 09:34:43 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: glarkin@FreeBSD.org References: <201201061944.q06JiwUR048089@repoman.freebsd.org> <4F0BF9F3.40009@FreeBSD.org> <4F0C2E7C.6070802@FreeBSD.org> <4F0CC4DF.6030906@FreeBSD.org> <4F0DB4F5.7020906@FreeBSD.org> In-Reply-To: <4F0DB4F5.7020906@FreeBSD.org> X-Enigmail-Version: 1.3.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Michael Scheidell , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Gabor Kovesdan , raven428@gmail.com, cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/devel/pinba_engine Makefile distinfo ports/devel/pinba_engine/files patch-src__ha_pinba.cc X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 17:34:44 -0000 On 1/11/2012 8:12 AM, Greg Larkin wrote: > On 1/10/12 6:08 PM, Doug Barton wrote: >> The correct fix is probably to remove that line and add something like >> (untested): > >> .if ${MYSQL_VER} == 52 >> MYSQL_PORTDIR= ${PORTSDIR}/databases/mariadb-server >> .else >> MYSQL_PORTDIR= ${PORTSDIR}/databases/mysql${MYSQL_VER}-server >> .endif > >> That should allow it to work with mariadb. > > Hi Doug, > > The line "${NONEXISTENT}:${MYSQL_PORTDIR}:configure" has been there > since the initial import, I was only going by the latest version of 'cvs annotate,' I didn't do an exhaustive search. Sorry if I created confusion about when/who, etc. > and the ":configure" portion adheres to the > description here: > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#AEN2138. Yeah, someone clued me in about that on IRC, but thanks. Just to be clear, I am not concerned about how the port does its thing. My only concern is that it work with mariadb. > Can you post the errors from the INDEX build? /usr/ports/devel/pinba_engine (pinba_engine-2011.08.18_1) Error. BUILD_DEPENDS /usr/ports/databases/mysql52-server -- dependency not found But once again, that's just a symptom. If the user sets WITH_MYSQL_VER= 52 in their make.conf this port will not build. > Since Pinba now supports MySQL 5.1.x+ and MariaDB 5.1.43+, the better > solution may be to present options to the user to select the database > backend, Um, no, that's exactly what should _not_ be done. :) The ports infrastructure already has a method for users to select what mysql version they want to use. This port needs to be made to work with it. That's all. Do you have a philosophical objection to the snippet I pasted in my last message? It's not pretty but I don't see why it wouldn't work, and provide minimal disruption to the way the port is structured currently. -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/