From owner-svn-src-all@freebsd.org Tue Sep 3 14:07:35 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5AC1EDCF76; Tue, 3 Sep 2019 14:06:48 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zq6Dh8z4Pw7; Tue, 3 Sep 2019 14:06:47 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id A91C31ABC5; Tue, 3 Sep 2019 14:06:17 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id BA4A11F2B8; Sat, 13 Apr 2019 01:16:39 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2FD4895A29; Sat, 13 Apr 2019 01:16:39 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 1E99A1F2B6; Sat, 13 Apr 2019 01:16:39 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id D509D1F2B3; Sat, 13 Apr 2019 01:16:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C3DD95A27; Sat, 13 Apr 2019 01:16:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x544.google.com with SMTP id z9so5954258pgu.10; Fri, 12 Apr 2019 18:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=XRSes/iCU5+saotM9wxglHk9v7qStNtJVfwMjuzfO64=; b=noFl8RsIl5+LvND48aBYe2NOrdbunKV2u5dCvq9wRUHLfnqlcWpneHZ3QMTpSRZXo+ otJxK7ZfSW4Y3XGzObZ3hmVIxl67u9j+XMCvFe3wJ521gmNDvcdkW9VX79ijNdH5Xxdn SBrbfRyK46e/ChK6wu7F4XVyu97WrOtXgq+2/stNyjvLA1UopgVA67BUYrl0xsdAMIha men7foqJ11Kys/TsER/roQWeUWkKp2ynz6dd5pqsiEAXDUSMugGfF+UTL6tZPBQVFDfh nNcy13wG1HueS1RdE7adIEuNaO/UuHLbgQHabLqd2AOd+872+DNTQqR8MHpsfCco5sTD TTag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=XRSes/iCU5+saotM9wxglHk9v7qStNtJVfwMjuzfO64=; b=XsY4TQEdyptaUZGdCIlT3+G9OQt/bxYD0Ja/O5320tA0WFsIhLXdlXv77u9w6txlsM sjM2EwKl42XQNty7e3mhU2kIYIThWAlFfjmMk2Lkq7YF4/2EeMDy1c1WRixT+b4qSNEw 8zLKgQmbfbDDGAP6Fl1febzhftjC+UmirFu1NmDpoj/BzRqcE5Xx6qZ1I/EXtE/fToFP 7phc8Hh88RpZAAZMc7sq+Gaut1mgr5G9IFC6fHbv8o3m0M4LMUsdA3cv5vrK5MjzTEmg Mhz/P7hrHph5JHK6SKSQtpWFvhawVmBqr4weV/mC/wnH/9dJVWeukNr+Bu3yuAx0qP9C TS9Q== X-Gm-Message-State: APjAAAW98PVE+xEiApO7TIswDp9gK1I58A5ov7BlDndE9csYjxW0CP09 1QVWCblJapIOHp803NpGnmxg4ueFz14= X-Google-Smtp-Source: APXvYqzXgFLx36R9d03X9k3tkPY9gTDH8z6YM+4qMM1qC9WI1XX8MJ275ytVkZbWmONEZ6LKAi77zQ== X-Received: by 2002:a62:ac02:: with SMTP id v2mr61029615pfe.163.1555118193640; Fri, 12 Apr 2019 18:16:33 -0700 (PDT) Received: from [192.168.20.21] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id o68sm105736075pfi.140.2019.04.12.18.16.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Apr 2019 18:16:33 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: svn commit: r346150 - head/sys/vm From: "Enji Cooper (yaneurabeya)" In-Reply-To: <4DA68C34-12A0-4E62-B868-F7BE10CB06BD@freebsd.org> Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201904121246.x3CCkP2m027680@repo.freebsd.org> <94A39E35-A8E0-42A4-8467-096D4AAD0F89@gmail.com> <4DA68C34-12A0-4E62-B868-F7BE10CB06BD@freebsd.org> To: Tycho Nightingale X-Mailer: Apple Mail (2.3445.104.8) Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 2FD4895A29 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.971,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:36 -0000 X-Original-Date: Fri, 12 Apr 2019 18:16:32 -0700 X-List-Received-Date: Tue, 03 Sep 2019 14:07:36 -0000 > On Apr 12, 2019, at 13:10, Tycho Nightingale = wrote: >=20 >> On Apr 12, 2019, at 12:43 PM, Enji Cooper = wrote: >>=20 >>=20 >>> On Apr 12, 2019, at 5:46 AM, Tycho Nightingale = wrote: >>>=20 >>> Author: tychon >>> Date: Fri Apr 12 12:46:25 2019 >>> New Revision: 346150 >>> URL: https://svnweb.freebsd.org/changeset/base/346150 >>>=20 >>> Log: >>> for a cache-only zone the destructor tries to destroy a non-existent = keg >>>=20 >>> Reviewed by: markj >>> Sponsored by: Dell EMC Isilon >>> Differential Revision: https://reviews.freebsd.org/D19835 >>=20 >>=20 >> Hi Tycho! >> Is the goal of this change to prevent a panic (with an = INVARIANTS kernel)? >> Thank you! >> -Enji >=20 > Hi, >=20 > The goal of this change is to fix a regression introduced in r343026. = It does cause a panic independent of INVARIANTS. Fortunately there = isn=E2=80=99t currently any in-tree code which triggers the panic. It = does however show up when running with the patch under review in D19845. Hi again! Thank you for the explanation! This part was missing from the = commit message, hence my question. I wanted to make sure I understood = the change in this commit properly. Cheers! -Enji=