From nobody Wed Feb 26 02:23:46 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z2dZG6qjKz5pRx5; Wed, 26 Feb 2025 02:23:50 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z2dZG6NQ5z3NLn; Wed, 26 Feb 2025 02:23:50 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740536630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hWeI3t+aDvNY7pBXSMz9lxI57twPQwfQ5OYw0R0TgBY=; b=oBjiie9+5K5gMmaXUeWvGM1ZVo5DrPbFy/h7MEdidh+OK55mw2zzhnWTcaaJqiyy8QQ17F RxNGB2Ypv8gjduiQtMCoOPBME91/h1gwYV/+Lk871Rp5jcxVZi+y0m+0GriMz4rDaenL2Y FTHgm+fy3ghRISX8PD0z3lNRvVGVTMGeMpY76NpjplGjmMuaDuCUVjmomsY3QfimpJ0mcL 2spESHS7eDqg/VKppSKVRQkpDqN1nQ/qFybyIcTzncApI+0akNDvE6nO+99UTm7woroHbM M7jUJHhZgNV2S353uF+6+98NBojbDnEMBi0jLMmoFtiDvwTCW6CEfpFxWpI86A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740536630; a=rsa-sha256; cv=none; b=yi9Q0wU5HVJxC+gYdiEoa6M/MradNnSDjsUKDscASdBgWsXMpydn+4SyEBtDZq/s0C3/mH NxLhv3tw8ogpgWeiGl1jpJ+4Ua49rez9+FsqqiK13zNzR35T1UnGRGeqFNFakeiT9WQ32z v/a7WvdTw9qsMLD02WAby39RMgMzJTnjdt8plV7YdfjUU/OzedrnIZ/DeU8xppdKmi8JWz o20ecC2GsFE7gSa1YwdgMRdvzckJ5aZpdTqXwRWOu7+c2v+CCnBVUD/9D6bRHIGi2f7F8t pzPC17wgcf5GcPfbPAgvcPGl7XxS1T/MOrm88/1It3dGP14axcL8IRMgsJIN4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740536630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hWeI3t+aDvNY7pBXSMz9lxI57twPQwfQ5OYw0R0TgBY=; b=UFYr24p6GElY9qE6Qb6wLDkg06rA/3MwmuIzShueZM3RpfbZGxVYTnCGAQLimfciEMiuIK js85KiAJ3vzNdhFfrkJ/Kmn3MXpKebpYzlKUr7fuPhwtMGspY0n/zoegT89WZzw8CDHVIF Cgx+FE+HGJTm2hTF+8b86DD8xhGqJRIk424ph5NuwwS91fFwaohge07AnMtFBUQFj4sg+H vPbO2QWNGVa3rYYXJS/8N/e1jpDrhbPxRAcNBb52a7SJJIF8V7tpGc5WNkS8t1g8UD6yfW u4/gKVZz/NET3q1HAQ3gzmCk+fIlnMtb2z6UccNrlpaU6FUpqiKWsBGx+7MMzQ== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E5" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z2dZG4yP4zMY5; Wed, 26 Feb 2025 02:23:50 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 9CC59A64805; Wed, 26 Feb 2025 02:23:47 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id E65562D029E0; Wed, 26 Feb 2025 02:23:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id KVMaVZViNVFH; Wed, 26 Feb 2025 02:23:47 +0000 (UTC) Received: from strong-rtwn0.sbone.de (strong-rtwn0.sbone.de [IPv6:fde9:577b:c1a9:4902:da44:89ff:fedd:d5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id BF74E2D029D8; Wed, 26 Feb 2025 02:23:47 +0000 (UTC) Date: Wed, 26 Feb 2025 02:23:46 +0000 (UTC) From: "Bjoern A. Zeeb" To: Michael Tuexen cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 0e58542fd246 - main - tcp: remove unused field from struct tcpcb In-Reply-To: <202502252048.51PKm4YX061305@gitrepo.freebsd.org> Message-ID: References: <202502252048.51PKm4YX061305@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Tue, 25 Feb 2025, Michael Tuexen wrote: > The branch main has been updated by tuexen: > > URL: https://cgit.FreeBSD.org/src/commit/?id=0e58542fd246242bc64bd03d8b2f28cf981c062b > > commit 0e58542fd246242bc64bd03d8b2f28cf981c062b > Author: Peter Lei > AuthorDate: 2025-02-25 20:37:48 +0000 > Commit: Michael Tuexen > CommitDate: 2025-02-25 20:37:48 +0000 > > tcp: remove unused field from struct tcpcb > > Reviewed by: tuexen > Sponsored by: Netflix, Inc. > --- > sys/netinet/tcp_var.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sys/netinet/tcp_var.h b/sys/netinet/tcp_var.h > index e65e44840bd8..31663ed48f81 100644 > --- a/sys/netinet/tcp_var.h > +++ b/sys/netinet/tcp_var.h > @@ -452,7 +452,6 @@ struct tcpcb { > tcp_seq gput_seq; /* Outbound measurement seq */ > tcp_seq gput_ack; /* Inbound measurement ack */ > int32_t t_stats_gput_prev; /* XXXLAS: Prev gput measurement */ > - uint32_t t_maxpeakrate; /* max peak rate set by user, bytes/s */ Is the tcpcb no longer KBI relevant these days? In the old days we'd simply make this a spare and not move all offsets below around. > uint32_t t_sndtlppack; /* tail loss probe packets sent */ > uint64_t t_sndtlpbyte; /* total tail loss probe bytes sent */ > uint64_t t_sndbytes; /* total bytes sent */ > -- Bjoern A. Zeeb r15:7