From owner-cvs-src@FreeBSD.ORG Sat Nov 4 22:10:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 801F716A403; Sat, 4 Nov 2006 22:10:46 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C09C43D62; Sat, 4 Nov 2006 22:10:45 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id BBA6E46CE9; Sat, 4 Nov 2006 17:10:43 -0500 (EST) Date: Sat, 4 Nov 2006 22:10:43 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: John Birrell In-Reply-To: <20061104203150.GB2027@what-creek.com> Message-ID: <20061104220921.Q14555@fledge.watson.org> References: <200611040458.kA44wAKN097086@repoman.freebsd.org> <20061104091155.GA12770@zaphod.nitro.dk> <20061104203150.GB2027@what-creek.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, John Birrell , cvs-all@FreeBSD.org, "Simon L. Nielsen" , src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/conf DEFAULTS src/sys/i386/conf DEFAULTS src/sys/ia64/conf DEFAULTS src/sys/pc98/conf DEFAULTS src/sys/powerpc/conf DEFAULTS src/sys/sparc64/conf DEFAULTS src/sys/sparc64/sparc64 machdep.c src/sys/sun4v/conf DEFAULTS X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2006 22:10:46 -0000 On Sat, 4 Nov 2006, John Birrell wrote: > On Sat, Nov 04, 2006 at 10:11:56AM +0100, Simon L. Nielsen wrote: >> Why isn't it just in GENERIC so people can easily disable it if they like? >> I thought DEFAULTS was just meant for things which caused users pain (and >> people answering support mails...) if they accidentally missed the option? >> I don't really see DTrace falling in that category. > > I added it to DEFAULTS so that it would be available automatically for > people who didn't know that they want it. 8-) > > Adding it to GENERIC doesn't cover the people who have their own kernel > configs. And they can still disable it in GENERIC or whatever config they > are using just as easily as they could add it. > > The point is that there is negligible run-time impact and only a small > increase in code size to have it enabled. Remember it's only the hooks and a > few support functions. The guts of DTrace is in the 'dtrace' kernel module > (and the associated providers) which still have to be loaded as modules. FYI: the way we now encourage people to customize the system is to include GENERIC and then customize from there, so putting it in GENERIC may make more sense if it's something people may actually want to remove. Robert N M Watson Computer Laboratory University of Cambridge