From owner-svn-src-projects@FreeBSD.ORG Thu Sep 2 19:53:04 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85880106582D; Thu, 2 Sep 2010 19:53:04 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 0233A8FC14; Thu, 2 Sep 2010 19:53:03 +0000 (UTC) Received: by qwg5 with SMTP id 5so981313qwg.13 for ; Thu, 02 Sep 2010 12:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=UAoc34+qkfue6l3M9pVOGJ0lQ+BLveDnIpQfE8K7nqM=; b=GGh1PcL+2CjVqMxHt5ZfrQH6fcDHFxGSmgx/SwAzovMMRjuiE5W2tAMgFrbwklXp/3 n0BR1Gh4Vf9WoNcYTwtT0ZCbl3lm7dzK6pvupnDWv5PLEeaUL1hQ2yOjrptGYN6E4K/6 +m50bwbotCfiXA2WfR/sCshMpRJ/7ndarQMAU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=ufrELzvQYwZ57chHspRj8RomJ1qGrj2m73GJ1t8uLNSY6q8eD32CVpwyCL//bwyK0q 3siniD4Vp5GA/cy9nTTAdWZUlsLGj8haSi3ed9cJ9q+tlEA+vinqD4LmfXYL6qzIYlIl AG5jrixe6PBKO9XDOsyYsBBNfhcFdtDR4bVGI= MIME-Version: 1.0 Received: by 10.224.53.35 with SMTP id k35mr6841998qag.250.1283457182991; Thu, 02 Sep 2010 12:53:02 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.229.222.209 with HTTP; Thu, 2 Sep 2010 12:53:02 -0700 (PDT) In-Reply-To: <20100902194309.GA36288@sandvine.com> References: <201009020933.o829XmS9098339@svn.freebsd.org> <20100902194309.GA36288@sandvine.com> Date: Thu, 2 Sep 2010 21:53:02 +0200 X-Google-Sender-Auth: 6_Ch-mGqrdwCEGgxRaKjnq1SKhs Message-ID: From: Attilio Rao To: Ed Maste Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org, Ryan Stone Subject: Re: svn commit: r212142 - in projects/sv/sys: amd64/amd64 arm/arm geom i386/i386 ia64/ia64 net powerpc/powerpc sparc64/sparc64 sun4v/sun4v sys X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2010 19:53:04 -0000 2010/9/2 Ed Maste : > On Thu, Sep 02, 2010 at 10:35:13AM -0400, Ryan Stone wrote: > >> On Thu, Sep 2, 2010 at 5:33 AM, Attilio Rao wrote: >> > Log: >> > =C2=A0Introduce a flag field for the dumpers and use it immediately fo= r the >> > =C2=A0DIF_NET flag. >> > =C2=A0This flag is responsible for toggling a netdump and having a cor= rect set >> > =C2=A0of dumplo in the dumping routines. >> > >> >> To be honest, I'd be happier if the DIF_NET flag disappeared entirely. >> =C2=A0It seems to me that dumpsys shouldn't need knowledge of disk geome= try >> -- especially now when there may not be a disk at all. =C2=A0It seems to= me >> that the correct interface would be for dumpsys to pass the offset >> into the core file to the dumper, and the dumper should convert that >> to a value appropriate for the dump device. > > I agree; in fact, on my ToDo list I've got: > > 14. dump_write API change to take offset (and add di->mediaoffset itself) > =C2=A0* makes netdumping slightly cleaner > > If this is the only use of DIF_NET flag then we certainly should be > able to get rid of it. Yes, I think that it should be eas(ish)y to do and I think it is a good ide= a. Thanks, Attilio --=20 Peace can only be achieved by understanding - A. Einstein