From owner-svn-src-all@freebsd.org Tue Nov 17 22:32:53 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 83904471146; Tue, 17 Nov 2020 22:32:53 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CbLLF0nXfz3nnd; Tue, 17 Nov 2020 22:32:52 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.229.168]) by shaw.ca with ESMTPA id f9Wqk0PpTbYg3f9Wsk71q3; Tue, 17 Nov 2020 15:32:51 -0700 X-Authority-Analysis: v=2.4 cv=Q4RsX66a c=1 sm=1 tr=0 ts=5fb44f93 a=7AlCcx2GqMg+lh9P3BclKA==:117 a=7AlCcx2GqMg+lh9P3BclKA==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=nNwsprhYR40A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=Hok_kDj2vMxL_LYshPwA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id B42BA6E1; Tue, 17 Nov 2020 14:32:47 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 0AHMWl7L074816; Tue, 17 Nov 2020 14:32:47 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202011172232.0AHMWl7L074816@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: John Baldwin cc: Warner Losh , Mateusz Guzik , Shawn Webb , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r367692 - head/sys/sys In-reply-to: <0015bc22-4568-93cc-5c77-e97c4f5e215c@FreeBSD.org> References: <202011141920.0AEJKbpO050396@repo.freebsd.org> <20201114205036.tnxvwarsddmu4shz@mutt-hbsd> <20201114205355.j2ejnhouipjr6yhk@mutt-hbsd> <0015bc22-4568-93cc-5c77-e97c4f5e215c@FreeBSD.org> Comments: In-reply-to John Baldwin message dated "Tue, 17 Nov 2020 14:18:07 -0800." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 17 Nov 2020 14:32:47 -0800 X-CMAE-Envelope: MS4xfCyYtta2fscw02WxefoOwinutjOLhdXA4ezbxQOJQ5ApZvWQdmOziSISl3mkkPCfHIUdACXhgMJCSweWYqVkqyKndFLNziWYOyQgdc2LivIWhzgP9atZ hhzyJ05anX6l7O9HCl1Cn9oTgAAhT3pWF/H9OkgQ5sokyqIfHkBVwL1ooihSRkWmEAaew0O2mV8xB4SHEoCDbhXMj89+j7W1D5J2jaT7erdlFpfilvJOahQQ xiaBydmml3vLWG55ZrtSkdFYBr8EuW4sqfz0TbyF4ywrDXY+ceFGgyB70lMpxkYcfjO9F9/0pAVLu05SS6hOacKOhrAPSX+VjNHJoiwEghuXGWWbnTb/fjSx eVm9l9lpaqjN8ua6G5cDA510OW1kHhPHcPRgxKvh6v0IZAWP63Y= X-Rspamd-Queue-Id: 4CbLLF0nXfz3nnd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 22:32:53 -0000 In message <0015bc22-4568-93cc-5c77-e97c4f5e215c@FreeBSD.org>, John Baldwin wri tes: > On 11/14/20 2:34 PM, Warner Losh wrote: > > true, but a version bump forces that and versions are cheap enough... > > Strictly speaking, version bumps don't force anything to recompile, they > just ensure that newer modules won't load on older kernels. In this case, > the change to sys/ucred.h will result in sys/ucred.h's mtime changing so > that any kernel modules being built via NO_CLEAN=yes will rebuild ok. > > I'm not quite sure where this mantra that version bumps force rebuilds > came from, but they don't. It's true that since it lives in > and most things include that, it mostly forces a rebuild, but that's > mostly a side effect, not due to explicit magic around __FreeBSD_version. Any update to sys/param.h causes the rebuild of any object that depends on the header file. It also causes any poudriere jail built on -CURRENT to delete all its packages and restart from scratch. Poudriere assumes it means ABI or API changes whereas version bumps could simply be markers of notable change that may not affect the ABI. In which case poudriere package rebuilds are gratuitous. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.