From owner-freebsd-questions  Mon Feb  3 12:54:40 2003
Delivered-To: freebsd-questions@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1123837B401; Mon,  3 Feb 2003 12:54:39 -0800 (PST)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4C54143F75; Mon,  3 Feb 2003 12:54:38 -0800 (PST)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.6/8.12.3) with ESMTP id h13KsV3Y006653;
	Mon, 3 Feb 2003 13:54:31 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Mon, 03 Feb 2003 13:51:59 -0700 (MST)
Message-Id: <20030203.135159.94296629.imp@bsdimp.com>
To: myevmenk@exodus.net
Cc: hackers@FreeBSD.ORG, questions@FreeBSD.ORG, brian@FreeBSD.ORG,
	doconnor@gsoft.com.au
Subject: Re: [PATCH] PPP in -direct mode does not execute any chat scripts
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <3E3ED4DF.7090904@exodus.net>
References: <45258A4365C6B24A9832BFE224837D552B1283@sjdcex01.int.exodus.net>
	<3E3ED4DF.7090904@exodus.net>
X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-questions@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-questions.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-questions>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-questions>
X-Loop: FreeBSD.ORG

In message: <3E3ED4DF.7090904@exodus.net>
            Maksim Yevmenkin <myevmenk@exodus.net> writes:
: Dear Hackers,
: 
: Please find attached patch that adds new option to the PPP.
: 
: 
: run-scripts-in-direct-mode
: 	Default: Disabled. This allows to run chat scripts in
: 	direct mode.
: 
: did i miss anything? objections? comments? reviews?

Maybe it would be better to call this "force-scripts" or something
more general purpose so that one could force the use of scripts
anywhere.  Making direct mode have a special case override seems a
little too restrictive.  The heart of the patch would become:

-  if (dl->physical->type & (PHYS_DIRECT|PHYS_DEDICATED))
+  if (!Enabled(dl->bundle, OPT_FORCE_SCRIPTS) &&
+      (dl->physical->type & (PHYS_DIRECT|PHYS_DEDICATED))
     /* Ignore scripts */
     runscripts = 0;

with corresponding changes to the docs, defines, etc.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-questions" in the body of the message