From owner-svn-ports-all@FreeBSD.ORG Mon Jun 23 12:22:24 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5E67A448; Mon, 23 Jun 2014 12:22:24 +0000 (UTC) Received: from mail-pd0-x22d.google.com (mail-pd0-x22d.google.com [IPv6:2607:f8b0:400e:c02::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1FD72216C; Mon, 23 Jun 2014 12:22:24 +0000 (UTC) Received: by mail-pd0-f173.google.com with SMTP id r10so5615297pdi.32 for ; Mon, 23 Jun 2014 05:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=3QSXmFKkX2YMxJAaz/gosQEPATojFwrtk/Ez0EQ1qrc=; b=Z9W8ipp17Tq2qHbgt4N4STylvWijcTMB4snTBe+DUd9XY+aU45kybfAtw5LcEQbmHx 9/kDJ5fhSTHO39EX6U0dl2X5NES6qf7OgLSPC5f09FXBSdZzxjENVDeBRd93s6etH2B0 CJxAlVhDs/oUJ8l6DoX14jy4lktDCIHj3OPNg36hkrOhja3HO6gGfqBkwp6jolQvbxYT H6LO8ol4lJdHJc5j/3Y08cGJsGdfD/o2lfWmmqs53h7qrtF6L7R4fILZHhl06kbbjS4q EGie12/yywzFtayLjz2wKYW9ZKvaqHMT3SwwBxADfttpaEt5QC1Fves5Yy+yCM/qBWD4 TyIw== X-Received: by 10.66.65.204 with SMTP id z12mr28181872pas.60.1403526143679; Mon, 23 Jun 2014 05:22:23 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b00:c48d:b807:77bf:b7c3? (2001-44b8-31ae-7b00-c48d-b807-77bf-b7c3.static.ipv6.internode.on.net. [2001:44b8:31ae:7b00:c48d:b807:77bf:b7c3]) by mx.google.com with ESMTPSA id si8sm92864968pab.27.2014.06.23.05.22.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jun 2014 05:22:23 -0700 (PDT) Sender: Kubilay Kocak Message-ID: <53A81BF9.9030305@FreeBSD.org> Date: Mon, 23 Jun 2014 22:22:17 +1000 From: Kubilay Kocak Reply-To: koobs@FreeBSD.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Raphael Kubo da Costa Subject: Re: svn commit: r358855 - head/databases/py-redis References: <201406222222.s5MMMCjr009114@svn.freebsd.org> <53A772FB.90908@FreeBSD.org> <867g48rt7r.fsf@orwell.Elisa> In-Reply-To: <867g48rt7r.fsf@orwell.Elisa> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jun 2014 12:22:24 -0000 On 23/06/2014 5:16 PM, Raphael Kubo da Costa wrote: > Kubilay Kocak writes: > >> On 23/06/2014 8:22 AM, Raphael Kubo da Costa wrote: >>> Author: rakuco >>> Date: Sun Jun 22 22:22:11 2014 >>> New Revision: 358855 >>> URL: http://svnweb.freebsd.org/changeset/ports/358855 >>> QAT: https://qat.redports.org/buildarchive/r358855/ >>> >>> Log: >>> - Updates to 2.10.1 >>> - Add support to build HTML documentation via sphinx. >>> >>> PR: 191267 >>> Submitted by: melvyn@magemana.nl (maintainer) >> >> Submitter is not maintainer, and patch has not been reviewed or QA'd yet. > > Sorry about that, I forgot to run make maintainer on this one. > >> Also, although I received the send-pr CC, it didn't make it into >> Bugzilla via gnats so I'm not sure how this was visible to others? > > I have a Bugzilla query that shows open bugs assigned to freebsd-ports@, > and this was one of them (without anyone else CC'ed other than the > submitter). > >> Can you please revert this change, or if that is inconvenient, commit a >> change that renames HTMLDOCS to the standard DOCS option name. > > I've submitted a follow-up patch to that bug; let me know if that's > enough, otherwise I'll just revert and bump PORTEPOCH. > All good Raphael, reverting is ugly so please feel free to own the update as well :) The changes look good, but I haven't had the chance to play with or test it yet. And thanks for being proactive on issue reports, we need more like you. -- koobs