From owner-svn-src-all@FreeBSD.ORG Tue Jan 26 14:28:03 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 94BB31065697; Tue, 26 Jan 2010 14:28:03 +0000 (UTC) Date: Tue, 26 Jan 2010 14:28:03 +0000 From: Alexey Dokuchaev To: Dag-Erling Sm??rgrav Message-ID: <20100126142803.GA55760@FreeBSD.org> References: <200911032022.nA3KM96H003434@svn.freebsd.org> <20100125192941.GA9196@FreeBSD.org> <86ljflj798.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <86ljflj798.fsf@ds4.des.no> User-Agent: Mutt/1.4.2.1i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Jung-uk Kim Subject: Re: svn commit: r198858 - in head/sys: dev/fb dev/syscons sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2010 14:28:03 -0000 On Tue, Jan 26, 2010 at 03:00:35PM +0100, Dag-Erling Sm??rgrav wrote: > Alexey Dokuchaev writes: > > Apparently this revision broke logo screen saver w/ vesa.ko on i386 (it > > works, but image is significantly darker). > > A darker image indicates that the BIOS is in 8-bit mode but the driver > thinks it's in 6-bit mode, so the driver right-shifts the palette > entries by two bits. Yup, I eventually started to think this is the case after reading through the code and the patch jkim@ sent me privately (which fixed the issue). Considering number of recent vesa/saver breaks, I am thinking about some regression test suit that could at least check for "8-bit vs. 6-bit" type of things. Is it feasible? ./danfe