From owner-svn-ports-all@FreeBSD.ORG Mon Feb 2 09:40:07 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F001758E; Mon, 2 Feb 2015 09:40:06 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C67E18FC; Mon, 2 Feb 2015 09:40:06 +0000 (UTC) Received: from [10.31.9.173] (unknown [213.225.137.129]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id A8F0843CA9; Mon, 2 Feb 2015 03:31:11 -0600 (CST) Message-ID: <54CF43DE.3020408@marino.st> Date: Mon, 02 Feb 2015 10:31:10 +0100 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Martin Matuska , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r378298 - head/ftp/proftpd References: <201502020916.t129Gc7D050708@svn.freebsd.org> In-Reply-To: <201502020916.t129Gc7D050708@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2015 09:40:07 -0000 On 2/2/2015 10:16, Martin Matuska wrote: > Author: mm > Date: Mon Feb 2 09:16:37 2015 > New Revision: 378298 > URL: https://svnweb.freebsd.org/changeset/ports/378298 > QAT: https://qat.redports.org/buildarchive/r378298/ > > Log: > Always compile with -pthread > > Modified: > head/ftp/proftpd/Makefile > > Modified: head/ftp/proftpd/Makefile > ============================================================================== > --- head/ftp/proftpd/Makefile Mon Feb 2 06:27:11 2015 (r378297) > +++ head/ftp/proftpd/Makefile Mon Feb 2 09:16:37 2015 (r378298) > @@ -101,9 +101,7 @@ PLIST_SUB+= LOCALSTATEDIR="${LOCALSTATED > .if !defined(_BUILDING_PROFTPD_MODULE) > CPPFLAGS+= -DHAVE_OPENSSL -I${OPENSSLINC} > LIBS+= -lssl -lcrypto -L${OPENSSLLIB} > -. if !defined(WITH_OPENSSL_PORT) > LDFLAGS+= -pthread > -. endif > .endif > > .if !defined(_BUILDING_PROFTPD_MODULE) > shouldn't that be "LDFLAGS+= -lpthread" ? I think we were told the case for "-pthread" is no longer valid and we should use -lpthread from now on (IIUC, -pthread eventually pulls in -pthread anyway) John