Date: Thu, 16 Feb 2012 23:26:06 +0100 From: Guido Falsi <mad@madpilot.net> To: Chris Rees <crees@freebsd.org> Cc: gnome@freebsd.org, FreeBSD Mailing List <freebsd-ports@freebsd.org> Subject: Re: PR ports/164449: update to finance/gnucash timeout Message-ID: <4F3D827E.6070000@madpilot.net> In-Reply-To: <CADLo83_JoL_omcVyhAzrECL5OUyE9%2B-r49s24-eAwmqS08wppw@mail.gmail.com> References: <20120213161546.GA95360@megatron.madpilot.net> <CADLo83_JoL_omcVyhAzrECL5OUyE9%2B-r49s24-eAwmqS08wppw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02/16/12 10:15, Chris Rees wrote: > On 13 February 2012 16:15, Guido Falsi<mad@madpilot.net> wrote: >> Hello, >> >> I'd like to ask if the PR in the subject can be committed due to >> maintainer timeout. > > Teams don't time out as such usually... I've CC'd gnome@ as a gentle poke. Thanks. I did not really know this. I'll remember this in the future. > > Your patch also uses the incorrect test "$var" == "value"; you should > only use one = sign with test. This will fail on 7.x. > Really sorry about this one. It just slipped in. But...This did not fail on redports 7.x tinderbox: https://redports.org/~madpilot/20120124141905-52190-7485/gnucash-2.4.9.log I would have checked this if it did. Anyway I'll remember to pay more attention in the future. -- Guido Falsi <mad@madpilot.net>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F3D827E.6070000>