From nobody Tue Jul 7 03:23:37 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gvRQd3rMvz6kl7Y for ; Tue, 07 Jul 2026 03:23:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gvRQc3KgKz3jT6 for ; Tue, 07 Jul 2026 03:23:52 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so25211685e9.0 for ; Mon, 06 Jul 2026 20:23:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783394630; x=1783999430; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Dc00wk4KDnBOtfx4irVCXH1/5An1Ln6MjOB2FYliRWM=; b=N1yeSsTcSTnXoJZDpxgQ6YnyChNkeFPwbel4Vbmu9Kgbw/1R49h1Q10RdaBUFqMgn4 RgNnU9qq/lBOO88qyGTneKWDdJ2+pW6Q3haTGck+DkUVx651YNPtEZe4A08x2uF6W9LZ A+6alxJ9UHPg4qsP/H43w177ekvw59TmUfdB52OmalOxvPXs8wkuKlQ7LNY2mqjFpS+U JGFhukRVzSmdRB1zmjjFL6g8mRuA+8zRLqPHImzLTSpOCsh3CAOOcEAtPpuUU0ZbM6MO W9wxQ9ZJW39Xm8kZ9POSBXubXPhzrBw6wv/INqWo0FDvPFLrSplpE0aZYtq3eZfxviAv hYrA== X-Forwarded-Encrypted: i=1; AHgh+RqMFHTNz1F4CXMhBRd3rRV1APlqlcJV5wfnjcgawsBHVB6BchKRCQewMzjaOBa7AB9NwU91cJL64jB6fQJ3YWEYmQCq@freebsd.org X-Gm-Message-State: AOJu0YxJOX2UZE1gNudNxA/mx1dEnA05w8ghmUXz813KGTKzkIcGVaAF Oe9EqpMzBHQxoILuvYugrAyqqBDMMzMxVFxMV3Y8cnYDnEff2fWXEYOM+hBUfGvwr5c= X-Gm-Gg: AfdE7ckp3+oqUC8Crnshhl3zj/rEufQHDXANYozSmOCGPUfeePNGpp96gmbJIK+/+El j3C/UIVBCheIUbzirMth2vjuWKO0HnySiiw/QpNhvcGhbjxmfgdQ9h3AZpNRPnZa/8hlLvMTk5a IGQ8y/MlYOdWc73zJNbJUNqqBOgS4rgBKUj0b87moiCMPka/pxFZvvHLCPx8FfsGRa5czPNZx5T JUs6d+gVq77RrU6zK/PsC1/IRQ77Vw0y2jdaSJmlDy+9x9/J7tvNVBl81JmTuKKuZpa1e9HwjGn Rwzhpy+C08dq2MWDYVfi/dvNxNLnAo0khD3C70UBqJWbLu03DkOq8tM6z1wSaMZWyHzVtPDuOsZ Y88/2DlmpxTHjE7C4z0BvvKl8x2tKaPGAA20Cw0DC4qiaBSIxTE/aROBzLk/FmrdXkbnppLPmJm 4cbJAYLWxu8ZfF/omD3CDD5QKbJHnFqzsE3kbI4a86NdnkV3EHGWUXgOhnBkg= X-Received: by 2002:a05:600c:3547:b0:493:72d3:4a81 with SMTP id 5b1f17b1804b1-493df041366mr31907115e9.16.1783394629904; Mon, 06 Jul 2026 20:23:49 -0700 (PDT) Received: from smtpclient.apple (nat-184-161.net.cam.ac.uk. [131.111.184.161]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e0f43912sm24136165e9.7.2026.07.06.20.23.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jul 2026 20:23:48 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3893.100.7.1.1\)) Subject: Re: git: 02ef0b6d76e9 - main - universe: allow moving build logs to UNIVERSE_LOGDIR From: Jessica Clarke In-Reply-To: <6a0f1540.3ff24.51dc4c5c@gitrepo.freebsd.org> Date: Tue, 7 Jul 2026 04:23:37 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <8E08C2FC-CC93-4374-A31F-C96DFF916A2B@freebsd.org> References: <6a0f1540.3ff24.51dc4c5c@gitrepo.freebsd.org> To: Siva Mahadevan X-Mailer: Apple Mail (2.3893.100.7.1.1) X-Spamd-Result: default: False [-2.40 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.996]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEFALL_USER(0.00)[jrtc27]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_HAS_DN(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.43:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.43:from] X-Rspamd-Queue-Id: 4gvRQc3KgKz3jT6 X-Spamd-Bar: -- On 21 May 2026, at 15:22, Siva Mahadevan wrote: >=20 > The branch main has been updated by siva: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D02ef0b6d76e9717b8e3182dd706e23fd= 2702701d >=20 > commit 02ef0b6d76e9717b8e3182dd706e23fd2702701d > Author: Siva Mahadevan > AuthorDate: 2026-05-20 20:05:53 +0000 > Commit: Siva Mahadevan > CommitDate: 2026-05-21 14:16:48 +0000 >=20 > universe: allow moving build logs to UNIVERSE_LOGDIR >=20 > This allows `make universe` or `make tinderbox` > to build from a read-only src tree. >=20 > Reviewed by: ziaee, imp, delphij > Approved by: lwhsu (mentor), emaste (mentor) > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D55566 > --- > Makefile | 17 ++++++++--------- > share/man/man7/build.7 | 7 ++++++- > 2 files changed, 14 insertions(+), 10 deletions(-) >=20 > diff --git a/Makefile b/Makefile > index 9308883b8500..e7a565cff05e 100644 > --- a/Makefile > +++ b/Makefile > @@ -599,8 +599,9 @@ targets: .PHONY > .endfor > .endfor >=20 > +UNIVERSE_LOGDIR?=3D${.CURDIR} > .if defined(DOING_TINDERBOX) > -FAILFILE=3D${.CURDIR}/_.tinderbox.failed > +FAILFILE=3D${UNIVERSE_LOGDIR}/_.tinderbox.failed > MAKEFAIL=3Dtee -a ${FAILFILE} > .else > MAKEFAIL=3Dcat > @@ -612,9 +613,7 @@ universe_prologue: .PHONY > @echo "--------------------------------------------------------------" > @echo ">>> make universe started on ${STARTTIME}" > @echo "--------------------------------------------------------------" > -.if defined(DOING_TINDERBOX) > @rm -f ${FAILFILE} > -.endif Hm, I don=E2=80=99t see an explanation for this change? This seems like = a separate thing, and changes behaviour even when UNIVERSE_LOGDIR isn=E2=80=99= t set? I can see the argument for doing it, but I don=E2=80=99t see any justification for it, whether in the commit message or in the Phabricator review, and it really belonged in its own commit IMO if making the change. Jessica