From owner-freebsd-audit Mon Jan 14 10:57: 9 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by hub.freebsd.org (Postfix) with ESMTP id F318A37B419; Mon, 14 Jan 2002 10:57:03 -0800 (PST) Received: from hades.hell.gr (patr530-a038.otenet.gr [212.205.215.38]) by mailsrv.otenet.gr (8.11.5/8.11.5) with ESMTP id g0EIuxY22213; Mon, 14 Jan 2002 20:57:01 +0200 (EET) Received: (from charon@localhost) by hades.hell.gr (8.11.6/8.11.6) id g0EIv3p30494; Mon, 14 Jan 2002 20:57:03 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Mon, 14 Jan 2002 20:57:02 +0200 From: Giorgos Keramidas To: Ruslan Ermilov Cc: audit@FreeBSD.ORG Subject: Re: last with -y option Message-ID: <20020114185702.GA30454@hades.hell.gr> References: <20020111232631.GA66629@hades.hell.gr> <20020114172454.G21333@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020114172454.G21333@sunbay.com> User-Agent: Mutt/1.3.25i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 2002-01-14 17:24:54, Ruslan Ermilov wrote: > On Sat, Jan 12, 2002 at 01:26:31AM +0200, Giorgos Keramidas wrote: > > The patch that was sent in PR bin/12982 does not apply to the > > usr.bin/last (probably because our last was modified for WARNS=2 after > > the patch was submitted), but I liked the idea that it describes. > > > > The attached patch adds a -y option to last that will print the year > > too when listing wtmp records. It also removes a few EOL whitespaces > > that I found while reading the last.c source. > > > > If this does not break any standards, and you don't think that it > > breaks last(1) in some way, I'll have to find myself an src/ committer > > to take care of this PR :-) > > > There're two functional and style bugs in your patch, see below. iewdose pointed out that many parts of the last.c source are duplicated in a lot of other places. I'll try to come up with changes that remove these duplicates first, and then add the -y option. This patch will be obsolete by then, but thanks Ruslan for taking the time to read/comment the changes. > Please don't commit unrelated whitespace changes together with functional > ones, commit them seperately. Good point. Thanks :) I'm not committing to src/ (apart from manpages) without approval anyway, but you're right. If/when last.c is changed I'll keep in mind to separate whitespace and content changes. -- Giorgos Keramidas . . . . . . . . . keramida@{ceid.upatras.gr,freebsd.org} FreeBSD Documentation Project . . . http://www.freebsd.org/docproj/ FreeBSD: The power to serve . . . . http://www.freebsd.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message