From owner-svn-src-all@FreeBSD.ORG Tue Nov 18 15:47:49 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B50C120E; Tue, 18 Nov 2014 15:47:49 +0000 (UTC) Received: from mail-wg0-x22b.google.com (mail-wg0-x22b.google.com [IPv6:2a00:1450:400c:c00::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 580FB8A2; Tue, 18 Nov 2014 15:47:49 +0000 (UTC) Received: by mail-wg0-f43.google.com with SMTP id l18so6554110wgh.30 for ; Tue, 18 Nov 2014 07:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=OE9pOtEN9HI6RT7rm/xM24kwnPH1I93xJNfeWlw0G+4=; b=m4X1XnrsqVYo0mM+JtrX0e0Jvtb/5iU5YcL6xiOwVD8D22cqM945BirHmjDaXKzT7R G52fGUyIYwyGPh7v8+iEPIjSHcUy4Kr5FNwAUEj4JFwR7Ur4ZF2sibgiSuiTtecO0iM0 +fnj7lcHgewUihiAqktpBwtiudc2OBNHCbAE/X+LlNcnbvT4qOZASNhP9qMqsfuPFzQ5 FpaWCUsw/RKPZs8WVYaN4LkBaMrmx+p4lee87iWPlWYMW2b1epKL9EE8Sl7DVNWwMqSH S/ihG1Trp45ioiFiHN86rQY2AKeOhdNT0CBPOeLAtyFqtL7jLjLMNU6K/QXOtme6khjF MMJQ== MIME-Version: 1.0 X-Received: by 10.180.83.98 with SMTP id p2mr4961175wiy.20.1416325666170; Tue, 18 Nov 2014 07:47:46 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.106.136 with HTTP; Tue, 18 Nov 2014 07:47:46 -0800 (PST) In-Reply-To: <20141118064626.GA956@dchagin.static.corbina.net> References: <201411172025.sAHKPLMl055666@svn.freebsd.org> <2245618.H2SPKlpWdS@ralph.baldwin.cx> <20141118064626.GA956@dchagin.static.corbina.net> Date: Tue, 18 Nov 2014 07:47:46 -0800 X-Google-Sender-Auth: z8cdXYS35KESugQlHmxFrmdcF3I Message-ID: Subject: Re: svn commit: r274635 - head/sys/dev/pci From: Adrian Chadd To: Chagin Dmitry Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 15:47:49 -0000 Hi, Want to post a bootverbose suspend/resume pass with -HEAD without this patch in it, then with this patch in it? We should likely revert this commit (for correctness) and then dig deeper into what's going on. -adrian On 17 November 2014 22:46, Chagin Dmitry wrote: > On Mon, Nov 17, 2014 at 05:45:23PM -0500, John Baldwin wrote: >> On Monday, November 17, 2014 08:25:21 PM Dmitry Chagin wrote: >> > Author: dchagin >> > Date: Mon Nov 17 20:25:21 2014 >> > New Revision: 274635 >> > URL: https://svnweb.freebsd.org/changeset/base/274635 >> > >> > Log: >> > Use the correct device as the power_for_sleep() method >> > always pass request up to parent bridge. >> > >> > Reviewed by: jhb >> > MFC after: 1 week >> > xMFC: r274386,r274397 >> >> Hmm, I had misread this diff as being another instance of what Adrian had >> found. I think this is actually not correct. The parent of a pci device >> ('dev' here) is a pciX device. pciX devices do not implement the >> PCIB_POWER_FOR_SLEEP method from pcib_if.m, so this probably just broke >> Adrian's Asus laptop as now it will always use D3 again and ignore _SxD. > ugh.. i understood, let me see more closely >> >> You said that this change fixed your laptop, yes? Did it work before Adrian's >> change in r274386 and break afterwards? > yes > > -- > Have fun! > chd