Date: Tue, 14 Aug 2012 14:26:38 +0200 From: Guido Falsi <mad@madpilot.net> To: Chris Rees <utisoft@gmail.com> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Eygene Ryabinkin <rea@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r302482 - in head/net-mgmt/pnp: . files Message-ID: <20120814122638.GA3839@micro.madpilot.net> In-Reply-To: <CADLo838QAghLaAHazRvsBbjjHHLoZ-feFzYTj%2BYjXLbJEjU9Lw@mail.gmail.com> References: <201208131956.q7DJuVcD086489@svn.freebsd.org> <50296355.4010601@madpilot.net> <0p2UjYrdAsNvQLQVHWx8Y/4z8R0@1THAFZvkF79ZxIfm0t9JFYgoGYY> <CADLo838FbaASxr6J9q=UbeBbbRAKtt4efL66xZMRsBcnW1k12w@mail.gmail.com> <Df2I/F7XrceCz3776WRT37AxvYA@1THAFZvkF79ZxIfm0t9JFYgoGYY> <CADLo838QAghLaAHazRvsBbjjHHLoZ-feFzYTj%2BYjXLbJEjU9Lw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 14, 2012 at 12:52:49PM +0100, Chris Rees wrote: > On 14 Aug 2012 12:47, "Eygene Ryabinkin" <rea@freebsd.org> wrote: > > > > Tue, Aug 14, 2012 at 12:21:13PM +0100, Chris Rees wrote: > > > On 14 Aug 2012 12:17, "Eygene Ryabinkin" <rea@freebsd.org> wrote: > > > > Anything about maintainer timeout or approval? > > > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=168408 > > > > > > I think he waited far longer than necessary. > > > > Sure, but that's not the point. The point is that when someone does > > some commit that needs maintainer approval, he should explicitely > > state in the commit message was it received, or was the timeout > > reached, or was it done due to some other reason. > > I see the confusion. > > The actual commit message does indeed contain the approval lines- I think > you must have missed the original mail. Yes, the original commit stated maintainer timeout, I checked. I just cut that part in the followup to correct the PR number. I'm quite ashamed for this mistake. I pasted the wrong number in there. My excuses again for this mistake. -- Guido Falsi <mad@madpilot.net>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120814122638.GA3839>