Date: Wed, 3 Mar 2021 09:09:12 -0500 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Warner Losh <imp@bsdimp.com>, Ed Maste <emaste@freebsd.org> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Brandon Bergren <bdragon@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2c26d77d989a - main - Remove /boot/efi from mtree, missed in 0b7472b3d8d2. Message-ID: <d6c729eb-7c72-2343-44cf-be1dda4cde68@freebsd.org> In-Reply-To: <CANCZdfqK9M50p2me%2BwkbSDWZomHmfdO1G6S08LRA6pdcpkrNZA@mail.gmail.com> References: <202103021856.122IuYgV048086@gndrsh.dnsmgr.net> <3d947e4c-a529-0b27-a8d7-415600783e53@freebsd.org> <CANCZdfpLa67OABBZWwPQPAJELOdkk4XSvkeH-3axjPa5-wR3%2BA@mail.gmail.com> <CANCZdfr8PXo%2BKuKedHToTtKP1H_-iGYu415QhtZQpp=r8TtV6A@mail.gmail.com> <CAPyFy2BpXmzw__QT4oerwG5aRaihNpULOKwL_vwsQJibiZgiYg@mail.gmail.com> <CANCZdfqK9M50p2me%2BwkbSDWZomHmfdO1G6S08LRA6pdcpkrNZA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/2/21 10:19 PM, Warner Losh wrote: > > > On Tue, Mar 2, 2021, 7:01 PM Ed Maste <emaste@freebsd.org=20 > <mailto:emaste@freebsd.org>> wrote: > > On Tue, 2 Mar 2021 at 19:30, Warner Losh <imp@bsdimp.com > <mailto:imp@bsdimp.com>> wrote: > > > > There has been some talk of moving the mount point to /efi, but > I think that went nowhere... > > I thought about /efi based on arguments from the Linux world, more > info at > https://wiki.archlinux.org/index.php/EFI_system_partition#Typical_m= ount_points > <https://wiki.archlinux.org/index.php/EFI_system_partition#Typical_= mount_points>. > I did open https://reviews.freebsd.org/D28814 > <https://reviews.freebsd.org/D28814>; to move the existing > uses to /efi. That said, I'm much more interested in us picking > something and using it in the installer/other tooling than whether > it's /boot/efi or /efi. > > > Me too. I am actually open to either. If I had a do over, I'd pick=20 > /efi honestly. > > But the directory presence or absence shouldn't be used to know if we=20 > have an ESP to deal with or not. > > Warner > It would have been nice to know that when I posted the original patch=20 for review that relied on this mechanism two weeks ago and you and Ed=20 both signed off. Or when we discussed this on Friday and no one knew why = it was in mtree -- I still honestly don't know from this thread -- and=20 then I proposed removing it and everyone said that was fine. There are=20 lots of other directories that we make in the installer that aren't in=20 mtree. What's special about this one? The problem here is that the installer needs to know if an ESP has been=20 made. If /boot/efi is supposed to be the mountpoint for an ESP, its=20 presence seemed like a reasonable way to signal that. Here are some optio= ns: - We could try to see if a partition is actually mounted there. That's=20 mildly annoying -- it involves parsing some shell output -- and results=20 in making a pointless directory on all non-EFI architectures. - We could try to have the installer signal to itself via some temp=20 file. This seems fragile and complicated. - We could duplicate the logic for whether to make an ESP in the first=20 place in several places, which seems like a terrible idea. But this needs to be settled *now*. It's already very, very late to get=20 this into 13.0 and we can't have another cycle of changing our minds=20 about reviewed code. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d6c729eb-7c72-2343-44cf-be1dda4cde68>