From owner-svn-src-projects@FreeBSD.ORG Mon Jan 12 21:33:08 2015
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id DFF2229E;
Mon, 12 Jan 2015 21:33:08 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
by mx1.freebsd.org (Postfix) with ESMTPS id 63FD4C4;
Mon, 12 Jan 2015 21:33:07 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t0CLX3xs022424
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
Tue, 13 Jan 2015 00:33:03 +0300 (MSK)
(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t0CLX32X022423;
Tue, 13 Jan 2015 00:33:03 +0300 (MSK)
(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
glebius@FreeBSD.org using -f
Date: Tue, 13 Jan 2015 00:33:03 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andrew Thompson <thompsa@FreeBSD.org>
Subject: Re: svn commit: r277071 - projects/ifnet/sys/sys
Message-ID: <20150112213303.GR15484@FreeBSD.org>
References: <201501121353.t0CDreu1022405@svn.freebsd.org>
<CAFAOGNTeDjuXY6_vHT1yQGueQRALD4hYbUZfPmH-CGQVWT0Qtw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFAOGNTeDjuXY6_vHT1yQGueQRALD4hYbUZfPmH-CGQVWT0Qtw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-projects@freebsd.org,
"src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the src " projects"
tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jan 2015 21:33:09 -0000
On Tue, Jan 13, 2015 at 10:25:05AM +1300, Andrew Thompson wrote:
A> > Author: glebius
A> > Date: Mon Jan 12 13:53:40 2015
A> > New Revision: 277071
A> > URL: https://svnweb.freebsd.org/changeset/base/277071
A> >
A> > Log:
A> > Provide struct mbufq, a STAILQ of mbufs, with counter for packets
A> > and maximum limit set. The structure is supposed to have external
A> > locking. The aim of new structure is to substitute struct ifqueue
A> > in several places in the kernel, where struct ifqueue is used
A> > outside of ifnet code itself.
A> >
A> > Modified:
A> > projects/ifnet/sys/sys/mbuf.h
A> >
A> > Modified: projects/ifnet/sys/sys/mbuf.h
A> >
A> > ==============================================================================
A> >
A> > +static inline int
A> > +mbufq_enqueue(struct mbufq *mq, struct mbuf *m)
A> > +{
A> > +
A> > + if (mbufq_full(mq))
A> > + return (ENOBUFS);
A> > + STAILQ_INSERT_TAIL(&mq->mq_head, m, m_stailqpkt);
A> > + mq->mq_len++;
A> > + return (0);
A> > +}
A> >
A> >
A>
A> > +static inline void
A> > +mbufq_prepend(struct mbufq *mq, struct mbuf *m)
A> > +{
A> > +
A> > + STAILQ_INSERT_HEAD(&mq->mq_head, m, m_stailqpkt);
A> > + mq->mq_len++;
A> > +}
A> >
A>
A> Should this have a full check like mbufq_enqueue?
Nope, the function is used to put back a recently dequeued mbuf that
failed to apply to somewhere else, and is too important to be dropped.
--
Totus tuus, Glebius.