From owner-freebsd-hackers Sun Jul 15 13:15:12 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from bremen.shuttle.de (bremen.shuttle.de [194.95.249.251]) by hub.freebsd.org (Postfix) with ESMTP id 4395837B406; Sun, 15 Jul 2001 13:15:08 -0700 (PDT) (envelope-from schweikh@schweikhardt.net) Received: by bremen.shuttle.de (Postfix, from userid 10) id 1B0E417D2E; Sun, 15 Jul 2001 22:15:07 +0200 (CEST) Received: (from schweikh@localhost) by hal9000.schweikhardt.net (8.11.4/8.11.3) id f6FKFRu02464; Sun, 15 Jul 2001 22:15:27 +0200 (CEST) (envelope-from schweikh) Date: Sun, 15 Jul 2001 22:15:27 +0200 From: Jens Schweikhardt To: "David O'Brien" Cc: hackers@freebsd.org Subject: Re: Whitespace at end of line Message-ID: <20010715221527.B1084@schweikhardt.net> References: <20010715155941.C1165@schweikhardt.net> <20010715111956.A71874@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010715111956.A71874@dragon.nuxi.com>; from obrien@freebsd.org on Sun, Jul 15, 2001 at 11:19:57AM -0700 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG David et al, On Sun, Jul 15, 2001 at 11:19:57AM -0700, David O'Brien wrote: # On Sun, Jul 15, 2001 at 03:59:41PM +0200, Jens Schweikhardt wrote: # > Dima and /me recently started weeding out white space at end of line for # > the man pages. I want to widen the weeding to include as much files as # > possible under /usr/src. # # Please do not do this to the .[ch] files. It makes diffs to stable harder. I see. Dima suggested in private email that I/we MFC such changes relatively fast in order to avoid that; of course this would be done only after md5 "approval" of the binaries. # You may not know this, but in the early history of the "new" CVS tree # (ie. /home/ncvs vs. /home/cvs) with the 4.4BSD Lite code someone did this # (including pulling files off the vendor branch). In the end this has # really irritated *many* a FreeBSD developer. Please leave such cleanup to # when people are in the files cleaning up other style nits so we don't # have 1 million commits, each taking care of just one point of style(9). OK, then I think it's best to tell developers@ about my script in freefall:~schweikh/bin/ws-at-eol which by default will only print the names of the files and optionally the line numbers/lines. Committers are encouraged to make use of it as they see fit. Folks, please remember to make separate commits for content changes and whitespace changes. $ ws-at-eol usage: ws-at-eol [options] directory ... Find whitespace at end-of-line in text files. Options: --help show this help text --remove remove whitespace at EOL using in-place editing --showlines print lines that have whitespace at EOL to stdout. EOL is marked by a $ sign, followed by a sequence of s and t characters for each space or tab. Examples: ws-at-eol /usr/src/share/man Regards, Jens -- Jens Schweikhardt http://www.schweikhardt.net/ SIGSIG -- signature too long (core dumped) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message