From owner-cvs-all@FreeBSD.ORG Mon Aug 11 21:23:35 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71205106567B; Mon, 11 Aug 2008 21:23:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 0ED7D8FC21; Mon, 11 Aug 2008 21:23:34 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m7BLNSRW069839; Mon, 11 Aug 2008 17:23:28 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Pawel Jakub Dawidek Date: Mon, 11 Aug 2008 13:06:00 -0400 User-Agent: KMail/1.9.7 References: <200808110841.m7B8fH4m067740@repoman.freebsd.org> In-Reply-To: <200808110841.m7B8fH4m067740@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808111306.00982.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Mon, 11 Aug 2008 17:23:29 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8009/Mon Aug 11 14:57:09 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.3 required=4.2 tests=AWL,BAYES_00, DATE_IN_PAST_03_06,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/glxsb glxsb.c glxsb_hash.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Aug 2008 21:23:35 -0000 On Monday 11 August 2008 04:41:08 am Pawel Jakub Dawidek wrote: > pjd 2008-08-11 08:41:08 UTC > > FreeBSD src repository > > Modified files: > sys/dev/glxsb glxsb.c glxsb_hash.c > Log: > SVN rev 181593 on 2008-08-11 08:41:08Z by pjd > > - Convert sc_sessions_mtx mutex to a rwlock, so in the fast path > (glxsb_process()) we don't block others when looking for our session. > - Simplify the loop responsible for freeing sessions on detach. > - No need to drop a lock around malloc(M_NOWAIT). > - Treat ses_used as boolean. > - Avoid gotos where possible. > - Various style(9) fixes. > > Reviewed by: philip, Patrick Lamaiziere Would it be worthwhile to abstract the session handling out of padlock(4) and glxsb(4)? Are there other CPUs with embedded crypto that will need their own drivers that having the abstraction would make writing a driver easier? -- John Baldwin