From owner-dev-commits-src-all@freebsd.org  Tue Feb  2 16:53:48 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id A456C537408;
 Tue,  2 Feb 2021 16:53:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DVW9S4Jvqz3mFb;
 Tue,  2 Feb 2021 16:53:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro.local (unknown
 [IPv6:2601:648:8681:1cb0:a03e:f824:f6c:d0c])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: jhb)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 193722AC7C;
 Tue,  2 Feb 2021 16:53:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
To: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@FreeBSD.org,
 dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
References: <202102011240.111CehGE094845@gitrepo.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Subject: Re: git: e92ab3adf4f9 - stable/13 - atomic: make atomic_store_ptr
 type-aware
Message-ID: <c8bd7ad4-0fa7-b75d-c2e2-84cd0930257b@FreeBSD.org>
Date: Tue, 2 Feb 2021 08:53:46 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <202102011240.111CehGE094845@gitrepo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Feb 2021 16:53:48 -0000

On 2/1/21 4:40 AM, Mateusz Guzik wrote:
> The branch stable/13 has been updated by mjg:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=e92ab3adf4f9848933439c9c2fca36df290c0884
> 
> commit e92ab3adf4f9848933439c9c2fca36df290c0884
> Author:     Mateusz Guzik <mjg@FreeBSD.org>
> AuthorDate: 2021-01-25 19:39:14 +0000
> Commit:     Mateusz Guzik <mjg@FreeBSD.org>
> CommitDate: 2021-02-01 12:39:16 +0000
> 
>      atomic: make atomic_store_ptr type-aware
>      
>      (cherry picked from commit cc96f92a570e05636a20fdd15d4616b127bb9ecc)

A couple of folks expressed concerns about this commit when it landed
in main due to it being too flexible (it allows you to store pointers
to non-pointer types, e.g.:

   char c;
   uintptr_t p;

   atomic_store_ptr(&c, p);

Silently becomes:

   atomic_store_char(&c, (char)p);

Are you planning to address this?

-- 
John Baldwin