From owner-freebsd-current@freebsd.org Mon Oct 5 03:40:43 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CBA5D3F495D; Mon, 5 Oct 2020 03:40:43 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C4RFk5T64z4b44; Mon, 5 Oct 2020 03:40:42 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-qt1-f169.google.com with SMTP id 19so8558670qtp.1; Sun, 04 Oct 2020 20:40:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=++LdxzMOM0S5MiGLU3GjNGlN4mm2JmXs1Z5qgtkm2d4=; b=LMIgrnFSxZxQce9NVHX0Vk44FioiWadrN6xa5B54wVFiYmQNAWydIk+wRSvN57ioL8 dRsJ78C6qprXt7DkTrAbqsrAQjrJX1dHhofWhlYSMnt5rcCGGDJBddaTvTDADT9AkizS SDQ2/qhQGK4ap5fHCXDtORjP6W8LEVGQ6zGbtlP1UCesYzvl9/q/uP/fZxzvDNs0pz5v 1y9tyoBaIV2TXZTWq9MWt8r05nTstRm8/awPCfFzIMi0fTAMH3z65Q3h6AeapzxdNaUK /Xwf8JO/0RqBJpaQxMlAu7rub1qc+JvrOWKOHnTAjOFL3LxkEtSf0KMv9gDWmtnmuwXf 7n3g== X-Gm-Message-State: AOAM532QllCKW4BkCRZpUUlshZTj56nAkT4SKXtKBpK8xFZe/AB3fGnf 0OkuLUwntWikJqDdqHQEfqKbvelQHu3oivh9SkQXJlOi X-Google-Smtp-Source: ABdhPJw9269ViPWiLce8EL4z+2bS12MtbBg1ChWvMO+3NeQN2OBebqQ/fWIZPMbj8AuTk7/ZcFJHaWllL59xBvJ9fFs= X-Received: by 2002:ac8:4e4e:: with SMTP id e14mr12718227qtw.49.1601869240508; Sun, 04 Oct 2020 20:40:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Sun, 4 Oct 2020 20:40:27 -0700 Message-ID: Subject: Re: mips32 + gcc9 -- still broken To: Alexander Richardson , Dimitry Andric Cc: freebsd-current , "freebsd-mips@freebsd.org" X-Rspamd-Queue-Id: 4C4RFk5T64z4b44 X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.02 / 15.00]; FROM_NEQ_ENVFROM(0.00)[adrian@freebsd.org,adrianchadd@gmail.com]; MAILMAN_DEST(0.00)[freebsd-current,freebsd-mips]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; ARC_NA(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[209.85.160.169:from]; RCVD_TLS_ALL(0.00)[]; NEURAL_HAM_LONG(-1.01)[-1.009]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_SHORT(-0.07)[-0.070]; RCVD_IN_DNSWL_NONE(0.00)[209.85.160.169:from]; NEURAL_HAM_MEDIUM(-0.94)[-0.945]; FORGED_SENDER(0.30)[adrian@freebsd.org,adrianchadd@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2020 03:40:43 -0000 ping! I've got the world building on gcc + mips32 just patching cxx_contention_t to be 32 bits, but it looks like an ABI change. Would the better thing be to just make it 32 bits on FreeBSD + MIPS for now? I don't think anyone is going to mind that changing at this point. -adrian On Sat, 3 Oct 2020 at 13:35, Adrian Chadd wrote: > > > On Mon, 21 Sep 2020 at 00:43, Alexander Richardson < > arichardson@freebsd.org> wrote: > >> >> On Mon, 21 Sep 2020, 07:38 Adrian Chadd, wrote: >> >>> So, the big list of unknown symbols was my fault! Whoops. >>> >>> i've gotten further using gcc-6.4 by fixing some of the warnings/issues >>> that have crept up. >>> >>> Here's a review for one of them: >>> >>> https://reviews.freebsd.org/D26504 >>> >>> However, now I've hit: >>> >>> /usr/local/bin/mips-unknown-freebsd13.0-ld: >>> >>> /usr/home/adrian/work/freebsd/head-embedded/obj/mips_ap/usr/home/adrian/work/freebsd/head-embedded/src/mips.mips/tmp/usr/lib/libc++.so.1: >>> undefined reference to `__atomic_fetch_sub_8' >>> /usr/local/bin/mips-unknown-freebsd13.0-ld: >>> >>> /usr/home/adrian/work/freebsd/head-embedded/obj/mips_ap/usr/home/adrian/work/freebsd/head-embedded/src/mips.mips/tmp/usr/lib/libc++.so.1: >>> undefined reference to `__atomic_load_8' >>> /usr/local/bin/mips-unknown-freebsd13.0-ld: >>> >>> /usr/home/adrian/work/freebsd/head-embedded/obj/mips_ap/usr/home/adrian/work/freebsd/head-embedded/src/mips.mips/tmp/usr/lib/libc++.so.1: >>> undefined reference to `__atomic_fetch_add_8' >>> >>> .. looks like we need some 64 bit atomics now in mips32 for libc++ / devd >>> >> >> Those are now provided by compiler-rt when using clang. With GCC you'll >> have to link libatomic. I had a quick look at the code in libc++ that uses >> the 64-bit atomics a few weeks ago and I believe it's the futex fallback >> code. The best solution would probably be to port it to use umtx but for >> MIPS32 it might be fine to use a 32 bit atomic instead. >> > > It compiled fine with a 32 bit atomic. Why's it 64 bit for everything but > Linux? > > Can we make it a 32 bit atomic for all FreeBSD platforms? Are there ABI > concerns? > > > > -adrian > > >> >> Alex >> >>>