Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Jun 2008 20:37:49 GMT
From:      Gleb Kurtsou <gk@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 144238 for review
Message-ID:  <200806282037.m5SKbnCX001230@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=144238

Change 144238 by gk@gk_h1 on 2008/06/28 20:37:47

	Include opt_ipfw.h before checking IPFIREWALL define. Without this fix
	previous revision was nop.
	Remove stale XXX comment.

Affected files ...

.. //depot/projects/soc2008/gk_l2filter/sys-net/if_bridge.c#7 edit

Differences ...

==== //depot/projects/soc2008/gk_l2filter/sys-net/if_bridge.c#7 (text+ko) ====

@@ -79,6 +79,7 @@
 
 #include "opt_inet.h"
 #include "opt_inet6.h"
+#include "opt_ipfw.h"
 #include "opt_carp.h"
 
 #include <sys/param.h>
@@ -2951,7 +2952,6 @@
 	if (((bifp ? bifp->if_flags : 0) | (ifp ? ifp->if_flags : 0)) & IFF_L2TAG) {
 		mtag_ether_header = m_tag_locate(*mp, MTAG_ETHER, MTAG_ETHER_HEADER,
 		    NULL);
-		/* XXX ??? can packet be tagged by another interface */
 		if (mtag_ether_header == NULL) {
 			mtag_ether_header = m_tag_alloc(MTAG_ETHER, MTAG_ETHER_HEADER,
 					ETHER_HDR_LEN, M_NOWAIT);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806282037.m5SKbnCX001230>