Date: Mon, 29 Oct 2012 02:59:10 -0600 From: Cpet Services <cpetservice@gmail.com> To: Raphael Kubo da Costa <rakuco@freebsd.org> Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/172976: fix for bugged patch in devel/flyspray 0.9.9.7 Message-ID: <CA%2BhK6Znb6O1%2BLa2hmgP2H=pHuBRUeHZhU6bTbipvZtPiVP1RhA@mail.gmail.com> In-Reply-To: <201210290830.q9T8U1Vp095785@freefall.freebsd.org> References: <201210290830.q9T8U1Vp095785@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
The patch supplied should really be used. Converting dos 2 unix should not have any real issues. As well options ng conversion which would need to be done anyways. The patch is such a small change that a simple reinplace should be enough Patch can be found here http://cpet.multics.org/patches/ports/patch-flyspray.txt On Oct 29, 2012 2:30 AM, "Raphael Kubo da Costa" <rakuco@freebsd.org> wrote: > The following reply was made to PR ports/172976; it has been noted by > GNATS. > > From: Raphael Kubo da Costa <rakuco@freebsd.org> > To: Nick Hilliard <nick@foobar.org> > Cc: Cpet Services <cpetservice@gmail.com>, bug-followup@FreeBSD.org > Subject: Re: ports/172976: fix for bugged patch in devel/flyspray 0.9.9.7 > Date: Mon, 29 Oct 2012 06:27:56 -0200 > > Nick Hilliard <nick@foobar.org> writes: > > > On 29/10/2012 00:04, Cpet Services wrote: > >> Using this: > >> > >> + @${REINPLACE_CMD} "s|E_ALL|E_ALL \& ~E_STRICT|g" \ > >> + ${WRKSRC}/includes/fix.inc.php > >> > >> As well as: > >> > >> +USE_DOS2UNIX= yes > >> > >> +DOS2UNIX_REGEX= .php > >> > >> You can remove the patch entirely > > > > I think this is a better approach than messing around with svn eol > > properties - thanks Chris. > > This will end up patching all PHP source files; if you're fine with > this, please file a new PR with a patch (preferrably CC'ing me) and I > can commit it. > _______________________________________________ > freebsd-ports-bugs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs > To unsubscribe, send any mail to " > freebsd-ports-bugs-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BhK6Znb6O1%2BLa2hmgP2H=pHuBRUeHZhU6bTbipvZtPiVP1RhA>