From owner-cvs-all Tue Dec 18 10:43:15 2001 Delivered-To: cvs-all@freebsd.org Received: from work.mysql.com (pD9E57C96.dip.t-dialin.net [217.229.124.150]) by hub.freebsd.org (Postfix) with SMTP id 7A95A37B417 for ; Tue, 18 Dec 2001 10:43:01 -0800 (PST) Received: (qmail 91996 invoked by uid 1000); 18 Dec 2001 19:44:20 -0000 Date: Tue, 18 Dec 2001 19:44:20 +0000 From: Sergei Golubchik To: Maxim Sobolev Cc: John Baldwin , Dirk Froemberg , cvs-all@freebsd.org, cvs-committers@freebsd.org Subject: Re: cvs commit: ports/databases/mysql323-server Makefile Message-ID: <20011218194420.A31061@serg.mysql.com> References: <1008630359.5329.2.camel@notebook> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <1008630359.5329.2.camel@notebook>; from sobomax@freebsd.org on Tue, Dec 18, 2001 at 01:06:31AM +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi! I would like to jump in as these options were taken from our script. On Dec 18, Maxim Sobolev wrote: > On Tue, 2001-12-18 at 00:53, John Baldwin wrote: > > On 17-Dec-01 Dirk Froemberg wrote: > > > dirk 2001/12/17 14:50:46 PST ... > > > - add BUILD_OPTIMIZED to add -mcpu=pentiumpro -O3 -fno-omit-frame-pointer > > > to CFLAGS (and thus to CXXFLAGS) > > > > You should not use -O3, it is known to produce buggy code. Use -O only, not > > even -O2. > > I agree with John - we should discourage anything above -O, not to > encourage it. Especially this applies to the databases, when the buggy > compiler output could do a lot of damage to the user's data. I think > BUILD_OPTIMIZED should be removed. Generally I agree. And I do prefer the program that works slow to the program that crashes fast. But these options were takes from the script that we (at MySQL AB) use to generate our official binaries. Every possible precausion is taken to ensure that our binaries are as stable is possible. So, -O3 is, most probably, very safe here. Regards, Sergei -- MySQL Development Team __ ___ ___ ____ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik / /|_/ / // /\ \/ /_/ / /__ MySQL AB, http://www.mysql.com/ /_/ /_/\_, /___/\___\_\___/ Osnabrueck, Germany <___/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message