From owner-cvs-all  Tue Apr  9  3:32:26 2002
Delivered-To: cvs-all@freebsd.org
Received: from mail.sat.t.u-tokyo.ac.jp (nat.keisu.t.u-tokyo.ac.jp [133.11.68.2])
	by hub.freebsd.org (Postfix) with ESMTP
	id 54D8B37B404; Tue,  9 Apr 2002 03:32:19 -0700 (PDT)
Received: from ett.sat.t.u-tokyo.ac.jp (ett.sat.t.u-tokyo.ac.jp [10.6.1.30])
	by mail.sat.t.u-tokyo.ac.jp (Postfix) with ESMTP
	id 028042DAC2; Tue,  9 Apr 2002 19:32:17 +0900 (JST)
Date: Tue, 09 Apr 2002 19:32:17 +0900
Message-ID: <ybswuvh17ta.wl@ett.sat.t.u-tokyo.ac.jp>
From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>
To: Nick Hibma <n_hibma@van-laarhoven.org>
Cc: Josef Karthauser <joe@tao.org.uk>,
	Hidetoshi Shimokawa <simokawa@FreeBSD.org>,
	"cvs-committers@FreeBSD.org" <cvs-committers@FreeBSD.org>,
	"cvs-all@FreeBSD.org" <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.c scsi_da.c
In-Reply-To: <20020409102222.M374-100000@heather.van-laarhoven.org>
References: <ybsy9fx1ews.wl@ett.sat.t.u-tokyo.ac.jp>
	<20020409102222.M374-100000@heather.van-laarhoven.org>
User-Agent: Wanderlust/2.4.1 (Stand By Me) REMI/1.14.3 (Matsudai) FLIM/1.13.2 (Kasanui) APEL/10.3 MULE XEmacs/21.2 (beta19) (Shinjuku) (i386-unknown-freebsd3.2)
X-Face: OE([KxWyJI0r[R~S/>7ia}SJ)i%a,$-9%7{*yihQk|]gl}2p#"oXmX/fT}Bn7:#j7i14gu$
 jgR\S*&C3R/pJX<mI-4Z8'mqt1R'CjWdw-xqVoilv`\JgZcquM5oVuO^<vt/~051rCDM(`{rM~?{Ok
 r,XC+}Ycm9IJO)odT*-0nyJjBJYzL{GsZ
MIME-Version: 1.0 (generated by REMI 1.14.3 - "Matsudai")
Content-Type: text/plain; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

At Tue, 9 Apr 2002 10:23:24 +0200 (CEST),
Nick Hibma wrote:
> > > The umass driver returns the error just fine. See many postings on this
> > > in the appropriate mailing lists.
> >
> > some drives(not driver) do, but some don't.
> 
> Don't do what? Return an error on receiving a command they don't
> understand? In that case your patch doesn't solve anything as the driver
> doesn't add or remove any error messages.

As fas as I observed at CAM layer, my USB HDD doesn't return any
(CAM or SCSI) error for READ_6, but csio->resid is still positive.

> > > At the moment the 6 byte commands are converted inside the umass driver
> > > to their 10 byte equivalents, so there should be no need for your patch
> > > in the first place (apart from the T_RBC bits of course, which looks
> > > like a good thing to me).
> >
> > I made this patch for SBP-II devices.
> 
> Did you try it with the umass driver from current?

No. It's really fine if current umass doesn't need quirks, because
many peopole suffer from 6 bytes command problem.

As for SBP-II/Firewire, I don't like to treat raw scsi commands
in SBP layer, so I decided to implement it in CAM layer.
I think it's nice because some SCSI like protocols(umass, sbp, iSCSI?)
can share the code.

/\ Hidetoshi Shimokawa
\/  simokawa@sat.t.u-tokyo.ac.jp
PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message