From nobody Tue Apr 23 20:04:13 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VPCkP62vsz5HyxB; Tue, 23 Apr 2024 20:04:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VPCkP4LhKz4kh7; Tue, 23 Apr 2024 20:04:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713902653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=psPrlt84z8YkVdbmmqVacr+S6N931DmbHEePspx6jHM=; b=pUqrRQ9didR3we5VUyvfsGgBvKWYNjnN6wOwT4abGbSiCKOCjj/L37F3hCfE5rCtX12JlM wH/aIadXDvvNyHjFj7fx7Tx6Eencjdwgrfivu9BI7OKnfxfIBiU3vMWMHV9IdWSPVOZWEs 9A0BFOOYGhFMNaznpI6FFiC3nb6SKq5gVIakviL8PxJR8nnfnmoRGNz+ppwJWuvkOy37Wa uDMMrrbJ7br51ooAbDn6IKc52/4JYdmFYbh39PmkeNYxtO4mPtvHsSnd/zgCHsg+PZf84a JXCqWmzQ1zBxsPwGPQPKczoWc78IfTqSVzNpyBuCgJ7GaESKg7TbQ/ix8iEpZw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713902653; a=rsa-sha256; cv=none; b=OzS5TbgEjOz709nS80AyrgiyhirMwQQrEtmAydIeF5YDVnnpZHsw/3+HWjkI1NDo/1UWMl tlciYaGWZqx926ocytppyR5AVketf/2dGpo4sTAWbGpozeqqsqezjoi77LjYSbtiLDw41f 5Ml/fBYklOqT47kzFzSPDevjdNy40d7Wyshr6U2VHPQIQINy2daTi8PoVKN2PdiVrs7mU2 91RxKKEE4h7bPQgSkfOPsszBVPXtfhoJWR9AVWC6JTbe60Z9XF5k6ButhXpD6MDw0HFLeR aLRN6iMObELex/MmYsp3eyzs6MWebZUV/zgn+XH4yPsGdSv+8EMbCFX9jqfaUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713902653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=psPrlt84z8YkVdbmmqVacr+S6N931DmbHEePspx6jHM=; b=irF4X8c6p0PatKIhhGbUDwEsZ/TjFlKewgNoXIWe/DoMxAYt2I6plmZa9ndMTtI4pl4PFk NarFyAH/w9dQj+2M472otp9/GoD4ZqTismh52DuXbfv30YMSHQdEInYNW0ruBjWIkCaIcp VIECj3lAzm4ELC3hM/4qvTjZB0wZh410PQ3CUXeWbnGeVwaHhW0WmB1uQlpz14EMR1xos0 5HpUs/+dk+tM2WnSSjf9VbmcJvkVeDKNKi/cXhS3Dl6TYQjpY4hIjm9iqhFqgtuIq2k60Q oetkUjLwE+kmRIxGqYIHBh04+4oIVlvbXwfU9KaW+kWYKDAV+4l/aGkvgUzFPw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VPCkP3yl1zlTY; Tue, 23 Apr 2024 20:04:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43NK4DG5012033; Tue, 23 Apr 2024 20:04:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43NK4DlJ012030; Tue, 23 Apr 2024 20:04:13 GMT (envelope-from git) Date: Tue, 23 Apr 2024 20:04:13 GMT Message-Id: <202404232004.43NK4DlJ012030@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: ea6f2d7797c4 - main - checkstyle9.pl: Warn if there's no SOB line List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ea6f2d7797c447e3c128b94ae7d825284a137600 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=ea6f2d7797c447e3c128b94ae7d825284a137600 commit ea6f2d7797c447e3c128b94ae7d825284a137600 Author: Warner Losh AuthorDate: 2024-04-23 20:03:28 +0000 Commit: Warner Losh CommitDate: 2024-04-23 20:04:08 +0000 checkstyle9.pl: Warn if there's no SOB line If there's no Signed-off-by: line, complain. Sponsored by: Netflix --- tools/build/checkstyle9.pl | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/build/checkstyle9.pl b/tools/build/checkstyle9.pl index df9ec2bbd7c1..7fa02bcabc97 100755 --- a/tools/build/checkstyle9.pl +++ b/tools/build/checkstyle9.pl @@ -1252,6 +1252,7 @@ sub process { my $in_header_lines = $file ? 0 : 1; my $in_commit_log = 0; #Scanning lines before patch + my $has_sob = 0; my $non_utf8_charset = 0; our @report = (); @@ -1456,14 +1457,17 @@ sub process { if ($line =~ /^\s*signed-off-by:/i) { # This is a signoff, if ugly, so do not double report. $in_commit_log = 0; + $has_sob = 1; if (!($line =~ /^\s*Signed-off-by:/)) { ERROR("The correct form is \"Signed-off-by\"\n" . $herecurr); + $has_sob = 0; } if ($line =~ /^\s*signed-off-by:\S/i) { ERROR("space required after Signed-off-by:\n" . $herecurr); + $has_sob = 0; } } @@ -2649,6 +2653,10 @@ sub process { } + if ($has_sob == 0) { + ERROR("Missing Signed-off-by: line"); + } + # If we have no input at all, then there is nothing to report on # so just keep quiet. if ($#rawlines == -1) {