From owner-svn-src-head@freebsd.org  Tue Aug 30 16:40:10 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94EDDBC8FF9;
 Tue, 30 Aug 2016 16:40:10 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7497DF19;
 Tue, 30 Aug 2016 16:40:10 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 522A5B953;
 Tue, 30 Aug 2016 12:40:09 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: "George V. Neville-Neil" <gnn@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r305066 - head/tools/tools/crypto
Date: Tue, 30 Aug 2016 09:34:03 -0700
Message-ID: <9289003.aPpUzvfJdT@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.3-STABLE; KDE/4.14.3; amd64; ; )
In-Reply-To: <201608301428.u7UESZKQ005906@repo.freebsd.org>
References: <201608301428.u7UESZKQ005906@repo.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Tue, 30 Aug 2016 12:40:09 -0400 (EDT)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Aug 2016 16:40:10 -0000

On Tuesday, August 30, 2016 02:28:35 PM George V. Neville-Neil wrote:
> Author: gnn
> Date: Tue Aug 30 14:28:35 2016
> New Revision: 305066
> URL: https://svnweb.freebsd.org/changeset/base/305066
> 
> Log:
>   Update cryptotest for modern algorithms
>   
>   Reviewed by:	cem
>   Sponsored by:	Rubicon Communications, LLC (Netgate)
>   Differential Revision:	https://reviews.freebsd.org/D7598

Doesn't removing 'static' result in a bunch of warnings from clang now since
you don't have function prototypes?  Assuming these functions aren't meant
to be exposed as a library to other programs, static is more correct.

-- 
John Baldwin