From owner-freebsd-gnome@FreeBSD.ORG Sat Apr 18 23:36:31 2009 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B96C106564A for ; Sat, 18 Apr 2009 23:36:31 +0000 (UTC) (envelope-from jonc@chen.org.nz) Received: from chen.org.nz (ip-58-28-152-174.static-xdsl.xnet.co.nz [58.28.152.174]) by mx1.freebsd.org (Postfix) with ESMTP id 413DE8FC18 for ; Sat, 18 Apr 2009 23:36:31 +0000 (UTC) (envelope-from jonc@chen.org.nz) Received: by chen.org.nz (Postfix, from userid 1000) id E89372840F; Sun, 19 Apr 2009 11:36:29 +1200 (NZST) Date: Sun, 19 Apr 2009 11:36:29 +1200 From: Jonathan Chen To: Joe Marcus Clarke Message-ID: <20090418233629.GA89603@osiris.chen.org.nz> References: <20090418105855.GA61453@osiris.chen.org.nz> <1240080177.18976.63.camel@shumai.marcuscom.com> <20090418204411.GA73963@osiris.chen.org.nz> <1240092470.18976.80.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1240092470.18976.80.camel@shumai.marcuscom.com> User-Agent: Mutt/1.4.2.3i Cc: freebsd-gnome@freebsd.org, Jonathan Chen Subject: Re: console-kit-daemon leaking file descriptors? X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2009 23:36:31 -0000 On Sat, Apr 18, 2009 at 06:07:50PM -0400, Joe Marcus Clarke wrote: > On Sun, 2009-04-19 at 08:44 +1200, Jonathan Chen wrote: > > On Sat, Apr 18, 2009 at 02:42:57PM -0400, Joe Marcus Clarke wrote: > > > On Sat, 2009-04-18 at 22:58 +1200, Jonathan Chen wrote: > > > > Hi, > > > > > > > > I'm running consolekit-0.3.0_6, and I'm seeing a file descriptor leak > > > > on /dev/null. A "fstat -p pid" on console-kit-daemon on my > > > > machine reveals that inode 7 (ie: /dev/null) has been opened with "r" > > > > 1000+ times after a week or so of uptime. > > > > > > > > Is anyone else seeing this? > > > > > > No. After a day and half of uptime, I have stdin, stdout, and stderr > > > open to /dev/null, plus one additional /dev/null on FD 4. If there was > > > a linear leak, I should have /dev/null open over 100 times by now. Can > > > you reliably reproduce this leak on your system? > > > > I've killed console-kit-daemon, and when it automatically restarts after > > a gdm login, I see the output below. 36 read-opens on /dev/null so > > far - which looks pretty suspicious. I'm running 7.1-STABLE FreeBSD > > as of "Apr 3 08:10:13 NZDT 2009". > > Does this patch fix the problem? > > http://www.marcuscom.com/downloads/patch-src_ck-sysdeps-freebsd.c Yes! Thanks heaps! -- Jonathan Chen ---------------------------------------------------------------------- Opportunities are seldom labeled