From owner-freebsd-current Sun Jan 26 23:27:04 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id XAA21663 for current-outgoing; Sun, 26 Jan 1997 23:27:04 -0800 (PST) Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id XAA21652 for ; Sun, 26 Jan 1997 23:26:59 -0800 (PST) Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id HAA29629; Mon, 27 Jan 1997 07:43:59 +0100 From: Luigi Rizzo Message-Id: <199701270643.HAA29629@labinfo.iet.unipi.it> Subject: Re: exec bug To: imp@village.org (Warner Losh) Date: Mon, 27 Jan 1997 07:43:59 +0100 (MET) Cc: dg@root.com, phk@critter.dk.tfs.com, swallace@ece.uci.edu, current@FreeBSD.ORG In-Reply-To: from "Warner Losh" at Jan 26, 97 06:04:04 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > In message <199701262144.WAA28837@labinfo.iet.unipi.it> Luigi Rizzo writes: > : int dont_panic_just_probing= 0; > > Wouldn't you need some other kind of locking in the SMP case? probably, yes. But I think my code has also worse problems, e.g. it is not reentrant. Since, as a result of the probe, you can get a page fault and the page should be read in, the dont_panic_just_probing variable should be saved somewhere together with the info related to the pagein. Anyways it was just a suggestion about the principle of operation, many details were missing and left to more knowledgeable people. Cheers Luigi -----------------------------+-------------------------------------- Luigi Rizzo | Dip. di Ingegneria dell'Informazione email: luigi@iet.unipi.it | Universita' di Pisa tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy) fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/ _____________________________|______________________________________