From owner-freebsd-virtualization@freebsd.org Wed Mar 7 17:14:13 2018 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3BD46F4160B for ; Wed, 7 Mar 2018 17:14:13 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A6FE681C2F for ; Wed, 7 Mar 2018 17:14:11 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w27HE3O5054614 for ; Wed, 7 Mar 2018 09:14:03 -0800 (PST) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w27HE31L054613 for freebsd-virtualization@freebsd.org; Wed, 7 Mar 2018 09:14:03 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201803071714.w27HE31L054613@pdx.rh.CN85.dnsmgr.net> Subject: Call for testing bhyve cpu topology additions To: freebsd-virtualization@freebsd.org Date: Wed, 7 Mar 2018 09:14:03 -0800 (PST) X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 17:14:13 -0000 There is a new version of the CPU topology review up at http://reviews.freebsd.org/D9930 I would like to ask that if people can test this and provide feedback that they do so. It has some undesired side effects on vm-bhyve and probably other down stream tools, I am in the process of contacting the vm-bhyve author to see what can be done to clean up this output (if you are here please respond to this thread): src-topo # vm list NAME DATASTORE LOADER CPU MEMORY VNC AUTOSTART STATE issd30g1 default bhyveload cpus=8,sockets=2,cores=4,threads=1 1024M - No Stopped Notice that due to the new CPU string being much more complicated than the normal int it makes the output format ugly. I have another change to vm-bhyve that I would like to see too, and that is to move the NAME to the end of the line and remove the 16 character limit. I have done that in my local copy already. This string and its parsing are designed to be Qemu compatible. Here is a sample of my local vm-bhyve vm list output (no topology used): /tmp # vm list DATASTORE LOADER CPU MEMORY VNC AUTOSTART STATE NAME default bhyveload 1 128M - No Stopped fb-bld-10-amd64 default bhyveload 1 128M - No Stopped fb-bld-11-amd64 default bhyveload 1 128M - No Stopped fb-bld-11.0-p1-amd64 default bhyveload 1 128M - No Stopped fb-bld-11.0-p1-i386 default bhyveload 4 512M - No Stopped fb-bld-11_1-amd64 default bhyveload 4 512M - No Stopped fb-bld-11_1-i386 default bhyveload 2 256M - No Running (30227) fb-bld-head-amd64 Thoughts are to teach vm-bhyve to parse the string just as bhyve does and only output the vCPU count. Other thoughts I have are to have it parse the string and output either vCPU if cores/threads is 1, or a simple S/C/T string. If you are a downstream maintainer of one of the other vm management packages I am open to input. The implemntation I have done should allow any existing tool that treated -c as a string to use the new topology without changes. This includes the in base vmrun.sh. Also people using the sysctls: hw.vmm.topology.cores_per_package: 1 hw.vmm.topology.threads_per_core: 1 can continue to do so at this time, but there is work in process to deprecate these, that work includes making stable/11 emit a warning message if they are used, and remove them in head/12. If I can get some significant test results back I plan to commit D9930 to ^head and merge it back to stable/11 3 days later. Thanks, -- Rod Grimes rgrimes@freebsd.org