From owner-svn-src-head@freebsd.org Wed Nov 15 20:27:20 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 508B5DE67A7 for ; Wed, 15 Nov 2017 20:27:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22f.google.com (mail-it0-x22f.google.com [IPv6:2607:f8b0:4001:c0b::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 165A57A5D9 for ; Wed, 15 Nov 2017 20:27:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22f.google.com with SMTP id m191so3277419itg.2 for ; Wed, 15 Nov 2017 12:27:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=eiqGsDTWTxDb8FaW8tXDObvaBmm1efukq8Pkme4qf1I=; b=wPU2s3rlKkPG4sRsBzqsvMwWIfxdm0l5ZzvgnQGJcm8+FM3xwhjNl6DeoogB9lH4it N4Vo9Suy7nUau/kUhfDMhDf0iw7qbdAlvZZgN220dICIG+z6QoPOFm6va35k9wAI2oRC m19z74MWAXjD6pm4MV/wHR9IclQnxRqzh5U+oUaeW0gnBjgpYgLbhor6DGQMoKks+kGD uafhHAuaZXtin2Fdlu0OUpGMJkvvrC5Y+F2mn2R+/6isvlHDNYxxYBWProN6JU2uAJay v2sS8pl0dmqgo7bQ0TyYZ7664I1sfWscQ9qglt34V2g1+O9HLW9NHKzUE4Zyvj8HKTM8 4D6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=eiqGsDTWTxDb8FaW8tXDObvaBmm1efukq8Pkme4qf1I=; b=pTGuls7lpFpJ+Erv5CNdDI8usb5cJuciJcbFoSpGUoYE9TZe9Ttch1vk58eGYRC+pm 2ldW42oi41zCmYOCoMZDhU5uB30TQbi3qhofLuFD9yBEoqH+I+KQO20x1pPBkq3V3lBb 2BbW9lc4p9hducAELF3cHduJ6JDN/+7/sxe6J3zuVfqI9go/GwsTdoBV4SX+LineMSbr TUrSjYpJCu+xxzgvnAyaAqnwlTVnQ2M1vUQeDxLiR0cfIOnUAyO9c400ZocuaxW9w7nH Qprd2S3QzYynCWXs8N3U8DJR9RsBbuoY6IzRllCzK8nKLXhIQ2OAEiCwXFQDJVCwkIRP 4kCQ== X-Gm-Message-State: AJaThX5iikTG8H5znzcwTdrcuUvlnrGxMZajUzsdyRijV/J7les0clC9 mHlts4Flj8q/QVyMuQ41eW/L8N6SWZ+GbXSf91M+hQ== X-Google-Smtp-Source: AGs4zMYBl8l1zHb5uDne33YR8eUXKVrgGuI6GvN2m8EIbzSLOVfZ6fEtFPPa7/PjRGb7sxSR0H81+/ubPnNtnd1M3uw= X-Received: by 10.36.184.5 with SMTP id m5mr22757581ite.69.1510777639395; Wed, 15 Nov 2017 12:27:19 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Wed, 15 Nov 2017 12:27:18 -0800 (PST) X-Originating-IP: [2607:fb90:6cbb:3482:ed95:2e8b:8936:7768] Received: by 10.79.108.204 with HTTP; Wed, 15 Nov 2017 12:27:18 -0800 (PST) In-Reply-To: <201711151847.vAFIlGD9052509@pdx.rh.CN85.dnsmgr.net> References: <201711151840.vAFIefKV002185@repo.freebsd.org> <201711151847.vAFIlGD9052509@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Wed, 15 Nov 2017 13:27:18 -0700 X-Google-Sender-Auth: TBoylCBsGooAslPDBRKqOdV7sug Message-ID: Subject: Re: svn commit: r325860 - head/sbin/newfs To: "Rodney W. Grimes" Cc: Ed Maste , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2017 20:27:20 -0000 On Nov 15, 2017 11:47 AM, "Rodney W. Grimes" wrote: > Author: emaste > Date: Wed Nov 15 18:40:40 2017 > New Revision: 325860 > URL: https://svnweb.freebsd.org/changeset/base/325860 > > Log: > newfs: warn if newer than kernel > > Creating a UFS filesystem with a newfs newer than the running kernel, > and then mounting that filesystem, can lead to interesting failures. > > Add a safety belt to explicitly warn when newfs is newer than the > running kernel. You should probably make the warning if (newer || older) as either is likely to have interesting side effects, as are mounting ufs file systems on different versions. Not really. The cg stuff is really only a hassle for the case ed is testing for. *Sigh* why did not UFS grow a version number of its own when things started to change other than UFS1 vs UFS2. This isn't anything like those changes.. Warner > Reviewed by: gjb, jhb, mckusick > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D12765 > > Modified: > head/sbin/newfs/newfs.c > > Modified: head/sbin/newfs/newfs.c > ============================================================ ================== > --- head/sbin/newfs/newfs.c Wed Nov 15 18:03:31 2017 (r325859) > +++ head/sbin/newfs/newfs.c Wed Nov 15 18:40:40 2017 (r325860) > @@ -398,6 +398,10 @@ main(int argc, char *argv[]) > if (pp != NULL) > pp->p_size *= secperblk; > } > + if (getosreldate() < __FreeBSD_version) { > + warnx("%s is newer than the running kernel and may not be compatible", > + getprogname()); > + } > mkfs(pp, special); > ufs_disk_close(&disk); > if (!jflag) > > -- Rod Grimes rgrimes@freebsd.org