From owner-svn-ports-all@FreeBSD.ORG Mon Jun 23 16:37:57 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5117FF61 for ; Mon, 23 Jun 2014 16:37:57 +0000 (UTC) Received: from mail-qa0-x22b.google.com (mail-qa0-x22b.google.com [IPv6:2607:f8b0:400d:c00::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CE5862A96 for ; Mon, 23 Jun 2014 16:37:56 +0000 (UTC) Received: by mail-qa0-f43.google.com with SMTP id k15so5895678qaq.16 for ; Mon, 23 Jun 2014 09:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=yuwmkASgWJIk8X+T1bVGYCAUMQhxrGgNOENZqrBG1AI=; b=GZ563O636mnNsyRlxCPMMcHjZwgm8Neq9N1pHQKUdw3uYwRBCW1kqlZWu8uJKaePSk /zUYVf5iS+AhQppgALV0TUMaUOqBnY1FPlQJ0yp2GX2TxkdUd7SRd6LTWUGqAn/3F0Qq zOPpQFOcQ9Pabx+R4TFU9+zgnAWGdD0bXd+Bs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=yuwmkASgWJIk8X+T1bVGYCAUMQhxrGgNOENZqrBG1AI=; b=kycwGZwORz5rETf5jWPGMblCHAlBhBJZpSA8EwUuDneW/U839wkIfghWjJ/bdbCgIU f2mBu0mwMB4EJqPr70Jl2NNSJpxdsjALHgaDDDBQnqis6BbA8LSisLkmV28AiBW0SV7l jdl4I9iN0KXzDHQ7fdLLAj+q1W6avBHSAnStVolBMz2TNDwbtgws9SNrGAbIekPv5Jec HFs+iTJ56Wykkg46Waumb+p3I8+WZMHwusBDuV3isn0PiRHU4l/t6o3lFgWKxoMCGYaa hzv7fYoF/dFiBJ46RJIV5br9fzDpW8Zzh41v3NtVmhhJzFHUZQmvWK72EpIHOnlRL5EW FM8g== X-Gm-Message-State: ALoCoQn2cV7Jj+hJe/nzjCBHQfBerPshZmpDw00Wels58PD1R1S2MmJq3hsw1GoQn2ZxOC/5PHrr X-Received: by 10.140.87.52 with SMTP id q49mr33352407qgd.43.1403541475966; Mon, 23 Jun 2014 09:37:55 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.96.222.131 with HTTP; Mon, 23 Jun 2014 09:37:25 -0700 (PDT) In-Reply-To: <20140623124533.GP23976@ivaldir.etoilebsd.net> References: <201406211708.s5LH8ZvE087036@svn.freebsd.org> <20140623124533.GP23976@ivaldir.etoilebsd.net> From: Eitan Adler Date: Mon, 23 Jun 2014 09:37:25 -0700 X-Google-Sender-Auth: z-72f4F-pXPQe5s9I0Ox6KMc1W8 Message-ID: Subject: Re: svn commit: r358722 - head/Mk To: Baptiste Daroussin Content-Type: text/plain; charset=UTF-8 Cc: Mathieu Arnold , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jun 2014 16:37:57 -0000 On 23 June 2014 05:45, Baptiste Daroussin wrote: > On Sat, Jun 21, 2014 at 10:17:19AM -0700, Eitan Adler wrote: >> On 21 June 2014 10:08, Mathieu Arnold wrote: >> > Author: mat >> > Date: Sat Jun 21 17:08:34 2014 >> > New Revision: 358722 >> > URL: http://svnweb.freebsd.org/changeset/ports/358722 >> > QAT: https://qat.redports.org/buildarchive/r358722/ >> > >> > Log: >> > Add a small notice about maintainership of this file. >> > >> > With hat: portmgr >> > Sponsored by: Absolight >> > >> > Modified: >> > head/Mk/bsd.options.desc.mk >> > >> > Modified: head/Mk/bsd.options.desc.mk >> > ============================================================================== >> > --- head/Mk/bsd.options.desc.mk Sat Jun 21 17:03:33 2014 (r358721) >> > +++ head/Mk/bsd.options.desc.mk Sat Jun 21 17:08:34 2014 (r358722) >> > @@ -7,6 +7,8 @@ >> > # - OPTION_DESC?= must be 19 characters or less >> > # - OPTION description text must be 43 characters or less >> > # >> > +# - This file's MAINTAINER is ports@FreeBSD.org so that entries can be added to >> > +# it easily. Any sweeping changes should be approved by portmgr. >> >> IMHO this is silly. The risk of changing description text is almost >> zero. Sweeping changes should be reviewed, but I don't think gating >> the review on a member of portmgr is useful. >> > Given what happened recently on those yes portmgr needs to review those sweep I'll copy what I wrote on phabricator: If anything, the recent commits proved that this statement is exactly opposite of what it should be. People add entries too easily, not realizing that this file is just a default. This means that new entries are often too general or useless. Also, people are too discouraged to change the descriptions when they are useless. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams