From owner-p4-projects@FreeBSD.ORG Tue Jun 10 01:32:52 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 0C82F106566C; Tue, 10 Jun 2008 01:32:52 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C11D91065675 for ; Tue, 10 Jun 2008 01:32:51 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.169]) by mx1.freebsd.org (Postfix) with ESMTP id 8D1E88FC13 for ; Tue, 10 Jun 2008 01:32:51 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: by wf-out-1314.google.com with SMTP id 24so2243112wfg.7 for ; Mon, 09 Jun 2008 18:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=zQPDQ/8v54ontimpT3j+6Gzo+CxsHQ1KrPeAXzVi1B4=; b=JyZN68UznUGoShseTPceUpTbG7quLShbaBPFOnQy+/oDiu8ay9PMRn14afq5HEYUUN YIfhoE7GbxXu+HM2wukysM8kRJbXXR1ZMeswte3RWCvoELxWqpl6n5u9aflff3tNpllg vcK96KrnNZeavnwj5VdYw5F+8uzhngUtsqavM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=eTtUqla4K+xWkX8TI/4dlPMGPU3SJV/iTWeueme5srPijawsM0XId+xaca3EmIMk5J F0rL+cU3BH0/KqeJ6OEkYhp5h2+ns8pCcOTbsR7guFILI1mnjM58UGJnpz1mae1PpoA7 QvAp4x8FPt1pYebzCDcjW54R/CDAzmK5AUqQ4= Received: by 10.142.52.18 with SMTP id z18mr1769070wfz.31.1213061568138; Mon, 09 Jun 2008 18:32:48 -0700 (PDT) Received: by 10.142.136.2 with HTTP; Mon, 9 Jun 2008 18:32:48 -0700 (PDT) Message-ID: <364299f40806091832g72ccee5ap462e698aea723f3b@mail.gmail.com> Date: Mon, 9 Jun 2008 18:32:48 -0700 From: "Garrett Cooper" To: "Anders Nore" In-Reply-To: <200806092250.m59Mog8G052587@repoman.freebsd.org> MIME-Version: 1.0 References: <200806092250.m59Mog8G052587@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Perforce Change Reviews Subject: Re: PERFORCE change 143220 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2008 01:32:52 -0000 On Mon, Jun 9, 2008 at 3:50 PM, Anders Nore wrote: > http://perforce.freebsd.org/chv.cgi?CH=143220 > > Change 143220 by andenore@andenore_laptop on 2008/06/09 22:49:41 > > Added the indexing of 'which' functionality in converter, and > pkg_info -W uses this index if cache is available, huge performance > boost compared to the old method. > > Affected files ... > > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/convert/converter.c#2 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/info/main.c#3 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/info/perform.c#3 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/lib/database.c#2 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/lib/global.c#2 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/lib/lib.h#3 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/lib/match.c#3 > edit Andre, Just one point: did you mean Port or Pkg? Remember that not all packages are ports, even though all ports can be packages. Otherwise, good work on the speedup and I'll be sure to help test out your repo-code if you like (IIRC pkg_install didn't have unit tests). Cheers, -Garrett