From owner-svn-src-head@freebsd.org Wed May 30 07:52:47 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36E14F756DE; Wed, 30 May 2018 07:52:47 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C4EC475586; Wed, 30 May 2018 07:52:46 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 02C5A260174; Wed, 30 May 2018 09:52:44 +0200 (CEST) Subject: Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool To: Antoine Brodin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201805280812.w4S8CI56046943@repo.freebsd.org> <383666b1-06a9-ac96-812f-c602c8e5e5af@selasky.org> <21342cd6-bf7e-263f-f077-2e073fe9ebef@selasky.org> From: Hans Petter Selasky Message-ID: <1cbed89b-e485-7f15-d3ab-f018024203eb@selasky.org> Date: Wed, 30 May 2018 09:52:32 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 07:52:47 -0000 On 05/30/18 09:36, Antoine Brodin wrote: > On Wed, May 30, 2018 at 7:31 AM, Hans Petter Selasky wrote: >> On 05/30/18 09:04, Hans Petter Selasky wrote: >>> >>> On 05/30/18 08:04, Antoine Brodin wrote: >>>> >>>> On Mon, May 28, 2018 at 10:12 AM, Hans Petter Selasky >>>> wrote: >>>>> >>>>> Author: hselasky >>>>> Date: Mon May 28 08:12:18 2018 >>>>> New Revision: 334277 >>>>> URL: https://svnweb.freebsd.org/changeset/base/334277 >>>>> >>>>> Log: >>>>> MFV r333789: libpcap 1.9.0 (pre-release) >>>>> >>>>> MFC after: 1 month >>>>> Sponsored by: Mellanox Technologies >>>> >>>> >>>> Hi, >>>> >>>> Some things seem to be missing. >>>> For instance, pcap_setsampling and pcap_open are now declared in >>>> pcap.h but they are not compiled in libpcap.so. >>>> net/p5-Net-Pcap is confused by this: >>>> >>>> http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p471115_s334360/logs/errors/p5-Net-Pcap-0.18.log >>> >>> >> >> Hi, >> >> net/p5-Net-Pcap is supposed to depend on and use net/libpcap which install >> into /usr/local/lib and /usr/local/include from what I understand. > > No, it worked fine with libpcap from base previously. > pcap/pcap.h now exposes functions from pcap-new.c but pcap-new.c is > not compiled. Hi, pcap-new.c is only compiled if libpcap should have remote support, which the in-base library didn't have? Can you try to modify the net/p5-Net-Pcap Makefile like this: BUILD_DEPENDS= p5-IO-Interface>=0:net/p5-IO-Interface \ libpcap>=0:net/libpcap CFLAGS+= -I${PREFIX}/include LDFLAGS+= -L${PREFIX}/lib --HPS