From owner-freebsd-embedded@FreeBSD.ORG Wed Mar 17 14:36:57 2010 Return-Path: Delivered-To: embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1FF3F106567A for ; Wed, 17 Mar 2010 14:36:57 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109]) by mx1.freebsd.org (Postfix) with ESMTP id B901C8FC25 for ; Wed, 17 Mar 2010 14:36:56 +0000 (UTC) Received: from localhost (unknown [213.17.239.109]) by smtp.semihalf.com (Postfix) with ESMTP id 9CBA9C42DD; Wed, 17 Mar 2010 15:39:38 +0100 (CET) X-Virus-Scanned: by amavisd-new at semihalf.com Received: from smtp.semihalf.com ([213.17.239.109]) by localhost (smtp.semihalf.com [213.17.239.109]) (amavisd-new, port 10024) with ESMTP id ZMlQQkoRQJnz; Wed, 17 Mar 2010 15:39:37 +0100 (CET) Received: from [10.0.0.34] (cardhu.semihalf.com [213.17.239.108]) by smtp.semihalf.com (Postfix) with ESMTPSA id D94D6C42D5; Wed, 17 Mar 2010 15:39:37 +0100 (CET) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii From: Rafal Jaworowski In-Reply-To: <4B9F72BC.1050609@semihalf.com> Date: Wed, 17 Mar 2010 15:36:53 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <1F3290BD-674B-4ED6-98DB-FCFE8B2DF4F4@semihalf.com> References: <0AE04EFA-A3EB-4939-BD81-607C00355B67@semihalf.com> <20100314165825.121d346b@fubar.geek.nz> <4B9E1697.9090602@semihalf.com> <20100316101044.0401295e@fubar.geek.nz> <4B9F72BC.1050609@semihalf.com> To: Grzegorz Bernacki X-Mailer: Apple Mail (2.1077) Cc: embedded@freebsd.org, Andrew Turner , Luiz Otavio O Souza Subject: Re: NAND Flash Framework for review X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2010 14:36:57 -0000 On 2010-03-16, at 12:59, Grzegorz Bernacki wrote: > Andrew Turner wrote: >> On Mon, 15 Mar 2010 12:14:31 +0100 >> Grzegorz Bernacki wrote: >>>>> Chip drivers: >>>>> - lnand and snand have magic numbers to figure out which drive to >>>>> use. We should move these to a flag in the chip parameters. >>>> We just need to add the chip size in nand_params and based on that >>>> we can calculate the number of address cycles (see below) and the >>>> type of chip (if chip >=3D 128MB and pagesize > 512 then you have a >>>> large page device). >>>>=20 >>> Yes, I was thinking about adding size of page and column address to >>> parameters of nfc_send_address. >> Why not just send each address byte separately like when the command = is >> sent? This will then push the requirement to know how many address >> bytes to the chip driver. >=20 > I choose to send whole address in one call to make implementation of = mpc8572 > driver easier. This controller requires to divide address into block = number and > page & column number and write them into corresponding registers. It = would be > complicated (however, not impossible) to combine full address from = bytes sending > via consecutive nfc_send_address calls. On the other hand sending = whole address > in one call should not complicated drivers for controllers which just = send address > byte after byte. For Andrewa nad Luiz reference I have submitted the existing MPC85XX = NAND back-end driver to the P4 branch. Rafal