From owner-svn-src-head@freebsd.org Wed Sep 13 19:28:57 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D37FE0BD89; Wed, 13 Sep 2017 19:28:57 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E602273999; Wed, 13 Sep 2017 19:28:56 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id sDL4d61nZDJTWsDL5dugqW; Wed, 13 Sep 2017 13:28:49 -0600 X-Authority-Analysis: v=2.2 cv=B4DJ6KlM c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=2JCJgTwv5E4A:10 a=6I5d2MoRAAAA:8 a=BWvPGDcYAAAA:8 a=pGLkceISAAAA:8 a=VxmjJ2MpAAAA:8 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=YxBL1-UpAAAA:8 a=CArGUo-jAyrTWHpj-QgA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=pxhY87DP9d2VeQe4joPk:22 a=6kGIvZw6iX1k4Y-7sg4_:22 a=7gXAzLPJhVmCkEl4_tsf:22 a=AjGcO6oz07-iQ99wixmX:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 2FED5410; Wed, 13 Sep 2017 12:28:46 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v8DJSTWV063084; Wed, 13 Sep 2017 12:28:29 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201709131928.v8DJSTWV063084@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Sean Bruno cc: Cy Schubert , Ngie Cooper , Stephen Hurd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys In-Reply-To: Message from Sean Bruno of "Wed, 13 Sep 2017 09:12:50 -0600." <48654d1f-4cc7-da05-7a73-ef538b431560@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 13 Sep 2017 12:28:29 -0700 X-CMAE-Envelope: MS4wfDqLvObsyh24Oj8pmKNWyfgK5juNQGr2S0gJROPjiQC3rssJ9NeP8XGr/xzqq7v3hzmJ2EeoyLQbkgdtS+9GPXPFATW8QaCpc6G1HmyrGfW1cPtp0kgs 5WurNJY9nJ+lIFKAWqnCGnFd9G0np4Gt8PuirGxb+b6qBOFdSD0JR9TeXeouIIqVAIzwb/vvdiIScKyhMjTXMYKVJC1810i9QG+b/MhWNC/m2YdmNf5+HbNq gkKb0gpSRkqVsjJtRdLX7LvQiTbnXtXKfoTbpaa78XGVxv1jbGt+Xd9LY/Ym21pTHX/4gBQQXf0IhZuhIkCbG5XgRR+WSXJ6M0YyLA5SH8TO+ATDtOQf4vtP RVtSHyYC X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 19:28:57 -0000 In message <48654d1f-4cc7-da05-7a73-ef538b431560@freebsd.org>, Sean Bruno write s: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --K3RXSO7fXoxBXqJUE1dpQ1sEQkuJPg1DQ > Content-Type: multipart/mixed; boundary="lalB5jI6dIhQxjTp1UFWH9Jx4OpW69Pfe"; > protected-headers="v1" > From: Sean Bruno > To: Cy Schubert , > Ngie Cooper > Cc: Stephen Hurd , src-committers@freebsd.org, > svn-src-all@freebsd.org, svn-src-head@freebsd.org > Message-ID: <48654d1f-4cc7-da05-7a73-ef538b431560@freebsd.org> > Subject: Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net > sys > References: <201709130711.v8D7BlTS003204@slippy.cwsent.com> > In-Reply-To: <201709130711.v8D7BlTS003204@slippy.cwsent.com> > > --lalB5jI6dIhQxjTp1UFWH9Jx4OpW69Pfe > Content-Type: text/plain; charset=utf-8 > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > >>> #blamebruno > >>> > >>> Reviewed by: sbruno > >>> Approved by: sbruno (mentor) > >>> Sponsored by: Limelight Networks > >>> Differential Revision: https://reviews.freebsd.org/D12235 > >> > >> *gasps at the LoC count and number of changed drivers* > >> > >> Could someone please better break this up in the future..? > >=20 > > Agreed. Down the road parsing out individual commits in this jumbo comm= > it=20 > > will be difficult to parse. IMO this may as well have simply been, impo= > rt=20 > > from https://github.com/mattmacy/networking/, just like Mr. Torvalds do= > es=20 > > at kernel.org. I expect to see a commit like this there but not here. C= > an=20 > > we break this down to its functional commits? > >=20 > >=20 > > > This ridiculous loc was due to the amount of restructuring needed to get > us back to being in sync with our development. The future will not have > this big of a commit/change and should be more bite/fun sized. > > The #blamebruno tag in the commit log was to indicate that this was not > something Stephen was doing on his own, but was something that I had > induced over the last few months during testing. I suppose it is sometimes unavoidable. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.