Date: Thu, 18 Mar 2004 10:00:28 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: Dag-Erling Sm?rgrav <des@des.no> Cc: FreeBSD Tinderbox <tinderbox@freebsd.org> Subject: sys/dev/sound/pci/vibes.c bug? [was: Re: [current tinderbox] failure on ia64/ia64] Message-ID: <20040318180028.GA60788@ns1.xcllnt.net> In-Reply-To: <xzpu10m5q73.fsf@dwp.des.no> References: <20040317040254.386947303A@freebsd-current.sentex.ca> <xzpad2fhixn.fsf@dwp.des.no> <20040317113931.GF49920@ip.net.ua> <20040317200307.GA46126@ip.net.ua> <20040317205104.GA29066@dhcp01.pn.xcllnt.net> <20040317213014.GB46747@ip.net.ua> <20040318084128.GA59199@dhcp01.pn.xcllnt.net> <xzpu10m5q73.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 18, 2004 at 12:50:56PM +0100, Dag-Erling Sm?rgrav wrote:
> Marcel Moolenaar <marcel@xcllnt.net> writes:
> > The source code appears to be fishy. The variable v is never used.
> > It's only defined. If you change the "return mask" to a "return v",
> > the warning goes away.
>
> I suspect that there's a line missing:
>
> @@ -548,4 +548,5 @@
> }
> DEB(printf("sv_mix_setrecsrc: mask 0x%08x adc_input 0x%02x\n", mask, v));
> + sv_indirect_set(sc, SV_REG_ADC_INPUT, v);
> return mask;
> }
>
> although I have no way of testing this.
Me neither. If this is likely to be missing and we don't have a
maintainer for the code, I suggest we just commit it. The function
cannot be more wrong than it is without the change...
[Subject line changed to attract PCM maintainer(s)]
--
Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040318180028.GA60788>