From owner-svn-src-all@freebsd.org Tue Aug 4 04:15:04 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2F199B334C; Tue, 4 Aug 2015 04:15:04 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 68A991FF; Tue, 4 Aug 2015 04:15:04 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t744EwKw068425 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 4 Aug 2015 07:14:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t744EwKw068425 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id t744EwIw068424; Tue, 4 Aug 2015 07:14:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 4 Aug 2015 07:14:58 +0300 From: Konstantin Belousov To: Jung-uk Kim Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286265 - head/sys/x86/include Message-ID: <20150804041458.GF2072@kib.kiev.ua> References: <201508040011.t740BeD3088014@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201508040011.t740BeD3088014@repo.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2015 04:15:05 -0000 On Tue, Aug 04, 2015 at 12:11:40AM +0000, Jung-uk Kim wrote: > Author: jkim > Date: Tue Aug 4 00:11:39 2015 > New Revision: 286265 > URL: https://svnweb.freebsd.org/changeset/base/286265 > > Log: > Always define __va_list for amd64 and restore pre-r232261 behavior for i386. > Note it allows exotic compilers, e.g., TCC, to build with our stdio.h, etc. > > PR: 201749 > MFC after: 1 week > > Modified: > head/sys/x86/include/_types.h > > Modified: head/sys/x86/include/_types.h > ============================================================================== > --- head/sys/x86/include/_types.h Tue Aug 4 00:11:38 2015 (r286264) > +++ head/sys/x86/include/_types.h Tue Aug 4 00:11:39 2015 (r286265) > @@ -152,8 +152,17 @@ typedef int ___wchar_t; > */ > #ifdef __GNUCLIKE_BUILTIN_VARARGS > typedef __builtin_va_list __va_list; /* internally known to gcc */ > -#elif defined(lint) > -typedef char * __va_list; /* pretend */ > +#else > +#ifdef __LP64__ > +typedef struct { > + unsigned int __gpo; > + unsigned int __fpo; > + void *__oaa; > + void *__rsa; > +} __va_list; What do the structure fields mean ? How is it related to the amd64 vararg ABI ? > +#else > +typedef char * __va_list; > +#endif > #endif > #if defined(__GNUC_VA_LIST_COMPATIBILITY) && !defined(__GNUC_VA_LIST) \ > && !defined(__NO_GNUC_VA_LIST)