From owner-cvs-src@FreeBSD.ORG  Fri Apr 16 04:05:39 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 314C116A4CE; Fri, 16 Apr 2004 04:05:39 -0700 (PDT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0CC5E43D5D; Fri, 16 Apr 2004 04:05:39 -0700 (PDT)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i3GB5agd022664;
	Fri, 16 Apr 2004 04:05:36 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i3GB5aEt022663;
	Fri, 16 Apr 2004 04:05:36 -0700 (PDT)
	(envelope-from rizzo)
Date: Fri, 16 Apr 2004 04:05:36 -0700
From: Luigi Rizzo <luigi@FreeBSD.org>
To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>
Message-ID: <20040416040536.A22418@xorpc.icir.org>
References: <200404160814.i3G8EYpj071288@repoman.freebsd.org>
	<20040416090520.GA1194@FreeBSD.org> <20040416023457.A12665@xorpc.icir.org>
	<xzpisg08a7g.fsf@dwp.des.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <xzpisg08a7g.fsf@dwp.des.no>;
	from des@des.no on Fri, Apr 16, 2004 at 12:54:11PM +0200
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Eivind Eklund <eivind@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if.c route.c rtsock.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2004 11:05:39 -0000

On Fri, Apr 16, 2004 at 12:54:11PM +0200, Dag-Erling Smørgrav wrote:
> Luigi Rizzo <luigi@FreeBSD.org> writes:
> > On Fri, Apr 16, 2004 at 09:05:20AM +0000, Eivind Eklund wrote:
> > > #define ifp2ifaddr(p) ifaddr_byindex((p)->if_index)
> > ifaddr_byindex() is already a macro, so i'd rather not have the
> > double indirection.
> 
> What difference does it make?

it is two different ways of getting the same info, which is
precisely what i was trying to remove in the first place.

But the most important thing is that we have to decide whether
the search key is the ifp or the ifindex, and use one consistently.

	cheers
	luigi